[#22068] - [4.0] Update RandomImageHelper.php
- Closed
- 14 May 2020
- Medium
- Build: 4.0-dev
- # 22068
- Diff
- Didldu-Florian:patch-2
- Success Hound No violations found. Woof! Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Fix for #22065 and improved code to scaled to the specified final height or width (so that the final height or width is not exceeded and there is no loss in dimension) why wrong complex, If it's that simple ;)
Pull Request for Issue #22065 .
Testing Instructions
See steps: #22065
Try once with custom height, once with custom width.
Once with both and once with empty height and width.
Expected result
Final height or width should be calculated in dimension even if no width or hight is set
Check px specification in width or heigt attibute (Not the given look, if huge px, because of box size limits possible ;)
Actual result
Works a bit complex without dimenson loss but it works only if width or hight is set!
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
| Labels |
Added:
?
|
||
franz-wohlkoenig
- | Title |
|
||||||
Please fix conflicting file.
Closing due to no response.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-05-14 18:15:21 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
Conflicting Files
|
||
@Didldu-Florian Could you please resolve the merge conflict so I can get this tested?