? Success

User tests: Successful: Unsuccessful:

avatar zero-24 zero-24 - open - 10 Oct 2013
avatar nonumber
nonumber - comment - 10 Oct 2013

The tags, note and version note fields should have a span12 (to be full width) (and any other text field you want full width).
All select fields should not have this.
None of the fields should have the 'small' class.

avatar beat
beat - comment - 10 Oct 2013

And those classes should be added in XML wherever possible ;-)

avatar nonumber
nonumber - comment - 10 Oct 2013

PS: Note and Version note is not the same.

avatar zero-24
zero-24 - comment - 10 Oct 2013

@nonumber thanks for your feedback :)

I think it looks bad if only some fields have span12 class and other not. So why we don't add span12 for all these fields have we a issue then or other problems?
Thanks :)

avatar nonumber
nonumber - comment - 10 Oct 2013

Having all fields get span12 makes it uglier and less easy to differentiate between the options (we did the tests).
Also, some field types don't work well with span12, like date selection fields and the yes/no btn-groups (too wide on wide screens).

So we only use span12 on only text fields that can use the full width. So fields that generally (can) contain more than one word.

avatar infograf768
infograf768 - comment - 11 Oct 2013

Another one for modules.
module_positions

avatar zero-24
zero-24 - comment - 11 Oct 2013

@nonumber thanks again.
so only the text fields using class="inputbox" should have class="inputbox span12" ? (I hope i understand you correct)
EDIT: and the other fields there are not a text field should not use span12?

@infograf768 thanks but i cant find the span12 class at a xml file for this or i'm wrong there?

avatar nonumber
nonumber - comment - 11 Oct 2013

Not sure all text fields have a class="inputbox" as that class isn't used for anything in isis. Not sure if hathor uses it. But the class is pretty much forgotten.

I think @infograf768 means that the Maximum Articles field could use a class="input-mini". Otherwise I have no idea what he means. Fields on the right look fine to me.

avatar infograf768
infograf768 - comment - 11 Oct 2013

@nonumber You are not wrong. It seems that the span3 has a width of 270px which is applied on this field.
With firebug, when I change locally to 220px, the field is fine but if I add a new class for #jform_position_chzn to 220px it is not applied properly

avatar nonumber
nonumber - comment - 11 Oct 2013

What field is fine? No idea what you are talking about or what you are trying to fix/change.

avatar zero-24
zero-24 - comment - 11 Oct 2013

@nonumber

Not sure all text fields have a class="inputbox" as that class isn't used for anything in isis. Not sure if hathor uses it. But the class is pretty much forgotten.

ok. so all fields that use type="text"?

avatar nonumber
nonumber - comment - 11 Oct 2013

No, like I said:

So we only use span12 on only text fields that can use the full width. So fields that generally (can) contain more than one word.

So on text fields like notes, yes, use span12.
On a text field that is meant to only hold a few characters, like the 'Maximum articles' field, use the input-mini. Or input-small for fields that should contain 0-10 characters.

avatar zero-24
zero-24 - comment - 11 Oct 2013

@nonumber

So on text fields like notes, yes, use span12.
On a text field that is meant to only hold a few characters, like the 'Maximum articles' field, use the input-mini. Or input-small for fields that should contain 0-10 characters.

ok. I will update the patch for this later. I start now to find out what fields should have span12 and which not :)
If i ready i update this here :)
Thanks again :)

avatar beat
beat - comment - 12 Oct 2013

Thanks @zero-24 :+1:

avatar zero-24
zero-24 - comment - 12 Oct 2013

@nonumber @beat
please see this image:

EDIT: can't upload the image here please wait a minute for a link

avatar zero-24
zero-24 - comment - 12 Oct 2013

Here the Link:
http://www.jah-tz.de/jb/joomlacode/span12.png

if this is ok i will change the PR for this
Thanks

@nonumber @beat

avatar beat
beat - comment - 12 Oct 2013

@zero-24 Looking purely on the image http://www.jah-tz.de/jb/joomlacode/span12.png :

Alignment of drop-downs and btn-groups look good.

That's at a given width, same for all ?, and version notes and tags will adapt to the span12 width, while drop-downs and btn-groups will stay that width ?

Would be good to take one of the views with tags and version note and show how they adapt to the width (showing right window border too).

avatar zero-24
zero-24 - comment - 12 Oct 2013

@beat

That's at a given width, same for all ?, and version notes and tags will adapt to the span12 width, while drop-downs and btn-groups will stay that width ?

yes

Would be good to take one of the views with tags and version note and show how they adapt to the width (showing right window border too).

see: http://www.jah-tz.de/jb/joomlacode/com_categories.JPG

avatar nonumber
nonumber - comment - 12 Oct 2013

Seems all good to me.

avatar beat
beat - comment - 12 Oct 2013

:+1: All good to me too, you can update your PR.
Thanks @zero-24 :-)

avatar zero-24
zero-24 - comment - 12 Oct 2013

@nonumber @beat
please test now :)

Thanks

avatar nonumber
nonumber - comment - 12 Oct 2013

Looks good.

avatar zero-24
zero-24 - comment - 13 Oct 2013

thanks @nonumber

avatar infograf768 infograf768 - close - 30 Oct 2013
avatar zero-24 zero-24 - head_ref_deleted - 30 Oct 2013
avatar garyamort garyamort - reference | - 2 Dec 13

Add a Comment

Login with GitHub to post a comment