? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
7 Sep 2018

This changes the label of the password field in the front end edit profile and the admin your profile screens to clarify that it is only if you want to change the password

image

image

At the same time some strings have been changed from "their" to "your" etc

pr for #21923

avatar brianteeman brianteeman - open - 7 Sep 2018
avatar brianteeman brianteeman - change - 7 Sep 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Sep 2018
Category Administration com_admin Language & Strings Front End com_users
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 8 Sep 2018

@ghost can you please Test this PR for your reported Issue?

avatar infograf768
infograf768 - comment - 8 Sep 2018

I have tested this item ? unsuccessfully on 0ceb4a8

I totally disagree about changing this user to you as the Basic Settings of a user in backend are not specifically modified for you.
It would only make sense if a user with access to manage users is editing his/her own profile.
For frontend it makes sense.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22045.
avatar infograf768 infograf768 - test_item - 8 Sep 2018 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 8 Sep 2018

Did you actually test this or read the instructions or look at the screenshots?
If you had then you would realise that I am not an idiot and that the changes are ONLY on pages where you are dealing with your OWN account.

avatar infograf768
infograf768 - comment - 8 Sep 2018

I did not test it, just looked at the .diff
Will test now.

avatar brianteeman
brianteeman - comment - 8 Sep 2018

Well i guess you didn't read the diff carefully or you would have realised that the changes are in
administrator/.../en-GB.com_admin.ini
and not in
administrator/../en-GB.com_users.ini

I will certainly need to be careful accepting your test reports in the future

avatar infograf768
infograf768 - comment - 8 Sep 2018

I will certainly need to be careful accepting your test reports in the future

That was a very useful comment. One should always verify test reports from anyone.

avatar infograf768 infograf768 - alter_testresult - 8 Sep 2018 - infograf768: Tested successfully
avatar infograf768
infograf768 - comment - 8 Sep 2018

modified test

avatar brianteeman
brianteeman - comment - 8 Sep 2018

Again I can only assume that you have not tested it or read the instructions or looked at the screenshots

On the admin page when editing a user on the site - NOTHING has changed
On the admin page when editing YOUR profile - the strings have been changed

avatar infograf768
infograf768 - comment - 8 Sep 2018

Can't you read?
I said above I modified my test.
https://issues.joomla.org/tracker/joomla-cms/22045

avatar brianteeman
brianteeman - comment - 8 Sep 2018

Yes - you said you disagree

I totally disagree about changing this user to you as the Basic Settings of a user in backend are not specifically modified for you.

But if you really tested you would see you are wrong

chrome_2018-09-08_09-37-25

chrome_2018-09-08_09-38-09

chrome_2018-09-08_09-42-46

chrome_2018-09-08_09-38-27

chrome_2018-09-08_09-38-39

chrome_2018-09-08_09-43-02

avatar brianteeman
brianteeman - comment - 8 Sep 2018

So when you said this you are wrong and cannot have tested or you would not disagree
image

avatar infograf768
infograf768 - comment - 8 Sep 2018

I said I modified my test, stop this game.
screen shot 2018-09-08 at 10 46 01

screen shot 2018-09-08 at 10 47 11

I was not going to delete all my comment above just to please your eyes.
Will bar it now.

avatar brianteeman
brianteeman - comment - 8 Sep 2018

It is not for my eyes it is for the benefit of others who would still see your objectiion

All you had/have to do is to write a new post saying "I was wrong and I have objection"

avatar brianteeman
brianteeman - comment - 8 Sep 2018

Thank you for correcting your post

avatar brianteeman brianteeman - change - 12 Sep 2018
Labels Added: ? ?
avatar brianteeman brianteeman - change - 8 Nov 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-11-08 13:18:21
Closed_By brianteeman
avatar brianteeman brianteeman - close - 8 Nov 2018

Add a Comment

Login with GitHub to post a comment