[#22020] - [4.0] Languager Strings in plg_quickicon_joomlaupdate
- Closed
- 6 Sep 2018
- Medium
- Build: staging
- # 22020
Steps to reproduce the issue
-
Set a custom url for joomla update. For testing you can use custom url https://www.jah-tz.de/downloads/core/gsoc18_override_management/gsoc18_update_list.xml
-
Start a joomlaupdate via https://www.jah-tz.de/downloads/core/gsoc18_override_management/gsoc18_update_list.xml
Expected result
All messages are correct.
Actual result
In control pane I see the messages are not correct.
System information (as much as possible)
The current 4.0-dev branch on ubuntu 18.04
Additional comments
I noticed this while I tested an other PR: #21851 (comment)
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
| Labels |
Added:
J4 Issue
Removed: ? |
||
franz-wohlkoenig
- | Status | New | ⇒ | Discussion |
| Category | ⇒ | com_joomlaupdate Language & Strings |
Looks like we have an error in the js. Not sure if it is the cause
${Joomla.JText._('PLG_QUICKICON_JOOMLAUPDATE_UPDATEFOUND_BUTOON')}</button>
instead of
PLG_QUICKICON_JOOMLAUPDATE_UPDATEFOUND_BUTTON
@infograf768 good spot. Will you do the PR for that please
I tested.
Although it is necessary to correct this typo, it does not solve the issue in Control Panel.
The problem is with the js code. After some corrections I can get.
Which is not perfect yet (the 0) but may depend from the package offered above as updating with it does not really change the J version.
Will try to make a PR this afternoon.
| Status | Discussion | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-09-06 10:28:04 |
| Closed_By | ⇒ | infograf768 |
Another issue with the joomla-alert custom element? :(