Feeling Lucky
J4 Issue
?
[#22017] - [4.0] hard coded strings dropdown.php
- Closed
- 14 Oct 2018
- Medium
- Build: staging
- # 22017
The file \layouts\joomla\toolbar\dropdown.php has several hard coded strings that should be translatable
Note it is not just as simple as creating a new string for the text that is there because the text is wrong
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Labels |
Added:
J4 Issue
|
||
franz-wohlkoenig
- | Status | New | ⇒ | Discussion |
| Category | ⇒ | Administration |
brianteeman
- comment
- 8 Sep 2018
Didldu-Florian
- comment
- 8 Sep 2018
Oh okay, yes, it's not translated and even not displayed.
I would suggest to remove these whole unnecessary line including associaded CSS
HLeithner
- comment
- 8 Sep 2018
some lines above is a aria-label:
What would you suggest to have as text brian?
Didldu-Florian
- comment
- 8 Sep 2018
"Toggle Dropdown" should better be placed as title attribute for the button itself ;)
HLeithner
- comment
- 8 Sep 2018
I think that "Toggle Dropdown" is pretty useless as aria label
Didldu-Florian
- comment
- 8 Sep 2018
One question: Do we have a prefered language key prefix for layouts?
HLeithner
- comment
- 8 Sep 2018
I think this text has to be set by the calling component.
| Status | Discussion | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-10-14 18:55:12 |
| Closed_By | ⇒ | brianteeman |
I can't find an usage of this layout in core. Can you point me in a direction?