[#22008] - [4.0] [a11y] Table Options
- Fixed in Code Base
- 4 Oct 2018
- Medium
- Build: 4.0-dev
- # 22008
- Diff
- brianteeman:filter_a11y
User tests: Successful: Unsuccessful:
The table options drop down contains multiple select inputs
None of them are accessible as they don't have a label or have an invalid label
This issue was identified by the JAT
The ‘select’ elements do not have corresponding labels
This PR adds a label for each select with a class of sr-only (screenreader only)
Unfortunately there is no label attribute present in the xml so I had to add it. To avoid creating more work for translators I am reusing (where possible) the language string we are using for the default empty value eg Select Position
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_modules Language & Strings Layout |
| Labels |
Added:
?
?
|
||
| Category | Administration com_modules Language & Strings Layout | ⇒ | Administration com_associations com_banners com_cache com_categories com_checkin com_contact com_content com_csp com_fields com_finder com_installer com_languages com_menus com_messages com_modules |
| Labels |
Removed:
?
|
||
| Title |
|
||||||
I have tested this item
I have tested it but cannot see any labels
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22008.
I have tested this item
I tried it but no labels appeared
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22008.
So you will not be able to "see" the labels - you need to look at the source to "see" them or to use a screenreader
@brianteeman we did check the source code of the site, no labels in sight. Not sure if that's a side effect of using the patchtester to apply the change, but I indeed can confirm @ceus1984 observation cause I was looking over here shoulder
@SniperSister dont know what to tell you
conflicts fixed
@infograf768 it is better if the labels are "Select" and not "- Select -"
So I can either create new strings for the label - disadvantage is that every extension will need to add the new strings to be accessible
Or I can change the strings to remove the " - " and then add the " - " in the select using css :before and :after disadvantage if 3pd extensions dont update their strings they will see "-- Select --"
I was mistaken screen readers dont announce the hyphen here
Closed - obviously no one else is interested in improving the accessibility in joomla 4
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-09-25 18:27:42 |
| Closed_By | ⇒ | brianteeman |
Trying again - maybe someone will look
| Status | Closed | ⇒ | New |
| Closed_Date | 2018-09-25 18:27:42 | ⇒ | |
| Closed_By | brianteeman | ⇒ |
| Status | New | ⇒ | Pending |
I've tested again. With patchtester it was not successful. I don't know why.
When I add the code manually into my branch, the test is successfull.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22008.
I have tested this item
I have tested this item successfully. The patchtester seems not to change the layout files, so this had to be done manually.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22008.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
Thanks all for Tests.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-10-04 07:22:59 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
?
|
||
Thanks
Thanks
I have tested this item✅ successfully on 20a908f
I have tested this item successfully but not with screenreader.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22008.