? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
4 Sep 2018

The border bottom was only set on thead th This pr correctly sets it on thead td as well

(cannot be tested with patchtester alone)

Before

chrome_2018-09-04_08-50-45

After

chrome_2018-09-04_09-20-28

avatar brianteeman brianteeman - open - 4 Sep 2018
avatar brianteeman brianteeman - change - 4 Sep 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Sep 2018
Category Administration Templates (admin)
avatar brianteeman
brianteeman - comment - 5 Sep 2018

For those that don't understand - it is not semantically correct to have a TH on a cell that is NOT a header. That cell must be a TD

avatar Wolf-Rost
Wolf-Rost - comment - 8 Sep 2018

I have tested this item successfully on 6bfa3fd

The provided fix worked as described.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21982.
avatar Wolf-Rost Wolf-Rost - test_item - 8 Sep 2018 - Tested successfully
avatar PLenz
PLenz - comment - 8 Sep 2018

I have tested this item successfully on 6bfa3fd

Tested successfull


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21982.

avatar PLenz PLenz - test_item - 8 Sep 2018 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 8 Sep 2018
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 8 Sep 2018

Ready to Commit after two successful tests.

avatar laoneo laoneo - change - 9 Sep 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-09-09 15:26:39
Closed_By laoneo
Labels Added: ?
avatar laoneo laoneo - close - 9 Sep 2018
avatar laoneo laoneo - merge - 9 Sep 2018
avatar laoneo
laoneo - comment - 9 Sep 2018

Thanks

avatar brianteeman
brianteeman - comment - 9 Sep 2018

thanks

Add a Comment

Login with GitHub to post a comment