Success

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
10 Oct 2013
avatar infograf768 infograf768 - open - 10 Oct 2013
avatar beat
beat - comment - 10 Oct 2013

Lots of changes in CSS that are not in LESS file. And other way around too.
I'm afraid that we get regressions elsewhere. We should check from which PR and FR the corresponding CSS lines came in before removing them, instead of adding them to LESS ?

avatar beat
beat - comment - 10 Oct 2013

what we did last time was go to phpstorm, open css file, right-click line number+"Annotate" before it got removed and see who addded the lines and in which PR for what. Then added back to LESS lines that were in CSS but not in Less
(for the ones that a new generatecss removes in CSS).

Only that way we can avoid a regression.

Add a Comment

Login with GitHub to post a comment