Feeling Lucky
?
?
[#21955] - [3.9] en-GB.plg_captcha_recaptcha.ini: Alpha sorting strings. Taking off blank lines before comments.
- Fixed in Code Base
- 2 Sep 2018
- Medium
- Build: 3.9-dev
- # 21955
- Diff
- joomla:infograf768-patch-2
- Pending continuous-integration/drone/push this build is pending Details
- Pending continuous-integration/travis-ci/push The Travis CI build is in progress Details
- Pending continuous-integration/appveyor/branch Waiting for AppVeyor build to complete Details
- Pending Hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
As title says.
Blank lines prevent seeing the comments on some translation systems.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings |
| Title |
|
||||||
| Labels |
Added:
?
?
|
||
brianteeman
- comment
- 2 Sep 2018
if blank lines are a problem then there are more files to review and fix
zero-24
- comment
- 2 Sep 2018
Ok merging this for now and the other one can be patched later. Thanks.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-09-02 15:10:30 |
| Closed_By | ⇒ | zero-24 |
infograf768
- comment
- 2 Sep 2018
if blank lines are a problem then there are more files to review and fix
I did that one because it was really a mess and time to fix its alpha order already in 3.9.
For the others, it is better to postpone to 4.0 imho.
brianteeman
- comment
- 2 Sep 2018
If it's a real problem, and I trust you when you say it is, then it should be fixed in j3 as that has a minimum of two years support when people need to translate joomla.
Looks good to me. Lets give Brian a bit more time to take a look so we can merge here.?