Joomla! Issue Tracker | Joomla! CMS #21943 - Editor change does not work

Closed
2 Sep 2018
Medium
Build: staging
# 21943

twister65
1 Sep 2018

Steps to reproduce the issue

Log in as administrator
System -> Global configuration
Change the Default Editor (Code Mirror)
Save & Close
Edit an article

Expected result

The editor has changed. The new one is Code Mirror, for example.

Actual result

The editor has not changed.
You have to select and save twice the editor to be taken into account.

System information (as much as possible)

Database : PostgreSQL v10.4
PHP Version : 7.1.20
Joomla! Version : Joomla! 3.8.12 Stable [ Amani ] 28-August-2018 14:00 GMT
Joomla! Platform Version : Joomla Platform 13.1.0 Stable [ Curiosity ] 24-Apr-2013 00:00 GMT
User agent : Mozilla/5.0 (Windows NT 10.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.106 Safari/537.36

Additional comments

twister65 - open - 1 Sep 2018

joomla-cms-bot - change - 1 Sep 2018

Labels

Added: ?

joomla-cms-bot - labeled - 1 Sep 2018

franz-wohlkoenig - change - 1 Sep 2018

System information

3.8.12
Template: Protostar
macOS Sierra, 10.13.6
Firefox 61 (64-bit)

CloudAccess.net

PHP 7.0.28
MySQLi 5.7.18-cll-lve

twister65 - change - 1 Sep 2018

The description was changed

twister65 - edited - 1 Sep 2018

twister65 - comment - 1 Sep 2018

systeminfo-2018-08-31T22_44_28-07_00.txt
I tried with PostgreSQL database.

ggppdk - comment - 1 Sep 2018

Maybe you have configured an editor specifically for this user
can you edit user and check ?

twister65 - comment - 1 Sep 2018

New installation (no update) with official Joomla_3.8.12-Stable-Full_Package.zip from joomla.org.
Log in as administrator with all the default options.
The problem is still relevant.
Please, see my system configuration :
systeminfo-2018-08-31T22_44_28-07_00.txt

twister65 - comment - 1 Sep 2018

The configuration.php file is correctly updated.
class JConfig { public $editor = 'codemirror';
But it is not reloaded when you edit an article.
You must log out and log back in.

alikon - comment - 1 Sep 2018

cannot replicate on staging with postgresql 9.6.8

twister65 - comment - 1 Sep 2018

Video screenshot : https://youtu.be/ygyZDMncchI

alikon - comment - 1 Sep 2018

franz-wohlkoenig - comment - 1 Sep 2018

@twister65 have you asked at forums?

twister65 - comment - 1 Sep 2018

franz-wohlkoenig - comment - 1 Sep 2018

i suggest to do so as there are on one Hand your Experience on the other not confirmings and this repository concerns in first Place Joomla-Core coding. Showing Videos didn't bring it to a Solution i guess.

SharkyKZ - comment - 1 Sep 2018

It's caching issue. OPCache in this case. We could invalidate configuration file cache like it's done in update script:

joomla-cms/administrator/components/com_joomlaupdate/restore.php

Lines 8317 to 8333 in 54de782

    
           					// opcode cache busting before including the filename 
        
           					if (function_exists('opcache_invalidate')) 
        
           					{ 
        
           						opcache_invalidate($filename); 
        
           					} 
        
           					if (function_exists('apc_compile_file')) 
        
           					{ 
        
           						apc_compile_file($filename); 
        
           					} 
        
           					if (function_exists('wincache_refresh_if_changed')) 
        
           					{ 
        
           						wincache_refresh_if_changed(array($filename)); 
        
           					} 
        
           					if (function_exists('xcache_asm')) 
        
           					{ 
        
           						xcache_asm($filename); 
        
           					}

twister65 - comment - 1 Sep 2018

Yes, it was a caching issue. Thank you, SharkyKZ. The editor is effectively changed with this commit :
twister65@8f27678

franz-wohlkoenig - comment - 1 Sep 2018

@twister65 can you please close the Issue?

twister65 - comment - 1 Sep 2018

Do you want a pull request ? Did you approve the changes ?

franz-wohlkoenig - comment - 1 Sep 2018

Yes, it was a caching issue.

Thats why i asked. If you do a Pull Request i say thank you :-)

twister65 - comment - 1 Sep 2018

##21949
Some checks were not successful
1 errored, 1 failing, and 2 successful checks

franz-wohlkoenig - change - 2 Sep 2018

Status	Discussion	⇒	Closed
Closed_Date	0000-00-00 00:00:00	⇒	2018-09-02 07:40:16
Closed_By		⇒	franz-wohlkoenig

joomla-cms-bot - change - 2 Sep 2018

Closed_By

franz-wohlkoenig

⇒

joomla-cms-bot

joomla-cms-bot - close - 2 Sep 2018

joomla-cms-bot - comment - 2 Sep 2018

Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/21943

franz-wohlkoenig - comment - 2 Sep 2018

closed as having Pull Request #21949

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#21943] - Editor change does not work

Steps to reproduce the issue

Expected result

Actual result

System information (as much as possible)

Additional comments

System information

CloudAccess.net

Add a Comment

	// opcode cache busting before including the filename
	if (function_exists('opcache_invalidate'))
	{
	opcache_invalidate($filename);
	}
	if (function_exists('apc_compile_file'))
	{
	apc_compile_file($filename);
	}
	if (function_exists('wincache_refresh_if_changed'))
	{
	wincache_refresh_if_changed(array($filename));
	}
	if (function_exists('xcache_asm'))
	{
	xcache_asm($filename);
	}