? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
30 Aug 2018

Pull Request for Issue # .

Summary of Changes

This corrects language variables used in com_media error strings.

Testing Instructions

Create a plugin that would cause file upload to fail. Something like this:

public function onContentBeforeSave($context, &$file, $isNew)
{
	if ($context === 'com_media.file')
	{
		$file->setError('Foo');

		return false;
	}
}

Attempt to upload a file.

Expected result

Upload fails with error:

An error occurred before saving the media: Foo

Actual result

Upload fails with error:

An error occurred before saving the media: 1

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 30 Aug 2018
avatar SharkyKZ SharkyKZ - change - 30 Aug 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Aug 2018
Category Administration Language & Strings
avatar tecpromotion
tecpromotion - comment - 15 Sep 2018

RTC? Any check needed?
Then I can prepare the German language pack.

avatar brianteeman
brianteeman - comment - 15 Sep 2018

@tecpromotion go for it

avatar zero-24
zero-24 - comment - 16 Sep 2018

Merging on review and the approval by Brian. Thanks.

avatar zero-24 zero-24 - change - 16 Sep 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-09-16 15:32:15
Closed_By zero-24
Labels Added: ? ?
avatar zero-24 zero-24 - close - 16 Sep 2018
avatar zero-24 zero-24 - merge - 16 Sep 2018

Add a Comment

Login with GitHub to post a comment