[#2192] - [fix] undefined elem.form.H5Form
- Closed
- 11 Oct 2013
- Medium
- Build: master
- # 2192
- Diff
- phproberto:html5fallback
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
@mbabker That insertion of system-message div is caused by html5back.js only. When @phproberto changes the focusout event handler to validateForm it is causing the error messages to render in that div. But since no error messages are present in the error.errors array none are shown an empty div still remained on the page. I am correcting that, just need to check if array length is not zero. Posting solution in 5 min.
if we wrap line https://github.com/phproberto/joomla-cms/blob/088c9f9a17e52070055097282982779d0ee59cb7/media/system/js/html5fallback-uncompressed.js#L362 in an if like
if(error.errors.length > 0) {
Joomla.renderMessages(error);
}
problem solves.
Both of the issues are covered in https://github.com/Achal-Aggarwal/joomla-cms/compare/form-field-fix.
Tracker in which @infograf768 mentioned it is http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32214
Not getting the console error anymore.
@Achal-Aggarwal - In testing this, I'm seeing an empty
<div id="system-message" class="alert alert-errors"></div>container show up on the page after an onchange event in a single field which remains until I leave the page. I'm pretty sure this patch isn't doing it but it's something that's coming up now that the html5fallback.js isn't kicking an error out. Could you look at this please?