Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#21919] - Add missing language string COM_USERS_LOGIN_DEFAULT_LABEL

? ? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
30 Aug 2018

Pull Request for Issue #21917 .

Summary of Changes

Add missing language string COM_USERS_LOGIN_DEFAULT_LABEL to language/en-GB/en-GB.com_users.ini.

@brianteeman Please review.

Testing Instructions

Code review:

  1. Check that this language string is already used in file components\com_users\models\forms\login.xml:
    <fieldset name="credentials" label="COM_USERS_LOGIN_DEFAULT_LABEL">
  2. Check that this language string is defined nowhere (with grep on Linux or findstr on Windows CMD).

Expected result

Language string "COM_USERS_LOGIN_DEFAULT_LABEL" defined.

Actual result

Language string "COM_USERS_LOGIN_DEFAULT_LABEL" not defined.

Documentation Changes Required

None.

avatar richard67 richard67 - open - 30 Aug 2018
avatar richard67 richard67 - change - 30 Aug 2018
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Aug 2018
Category ⇒ Language & Strings
avatar richard67 richard67 - change - 30 Aug 2018
Title
…
Add missing language string
Add missing language string COM_USERS_LOGIN_DEFAULT_LABEL
avatar richard67 richard67 - edited - 30 Aug 2018
avatar richard67 richard67 - change - 30 Aug 2018
The description was changed
avatar richard67 richard67 - edited - 30 Aug 2018
avatar richard67 richard67 - change - 30 Aug 2018
The description was changed
avatar richard67 richard67 - edited - 30 Aug 2018
avatar brianteeman
brianteeman - comment - 30 Aug 2018

If the language string is never used then it should be removed. Translating it will be a waste of translators time

avatar richard67
richard67 - comment - 30 Aug 2018

Ok, waiting for further information in the issue.

avatar franz-wohlkoenig franz-wohlkoenig - change - 30 Aug 2018
Priority Medium ⇒ Low
avatar franz-wohlkoenig franz-wohlkoenig - change - 30 Aug 2018
Priority Low ⇒ Medium
avatar mbabker
mbabker - comment - 30 Aug 2018

If the language string is never used then it should be removed. Translating it will be a waste of translators time

Core doesn't render this fieldset's label. However, as shown in the related issue, templates may opt to render fieldset labels where core isn't. For me, this PR is just fine.

avatar brianteeman
brianteeman - comment - 30 Aug 2018

Now we have seen the screenshot this pr makes sense.

avatar richard67
richard67 - comment - 30 Aug 2018

@madmetz Please test and mark your test result in the issue tracker.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21919.

avatar infograf768
infograf768 - comment - 30 Aug 2018

I have tested this item ✅ successfully on 4ee0091

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21919.

avatar infograf768 infograf768 - test_item - 30 Aug 2018 - Tested successfully
avatar zero-24
zero-24 - comment - 30 Aug 2018

@mbabker can you please suggest the milestone this would get merged into? Is this the 3.9. release or would it be a 3.8.13?

avatar mbabker
mbabker - comment - 30 Aug 2018

There is no 3.8.13 planned.

avatar zero-24
zero-24 - comment - 30 Aug 2018

Ok tagging than for 3.9.0 and merging into staging for now. Thanks!

avatar zero-24 zero-24 - close - 30 Aug 2018
avatar zero-24 zero-24 - merge - 30 Aug 2018
avatar zero-24 zero-24 - change - 30 Aug 2018
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-08-30 18:20:18
Closed_By ⇒ zero-24
Labels Added: ? ?

Add a Comment

Login with GitHub to post a comment