J4 Issue
avatar brianteeman
brianteeman
29 Aug 2018

Steps to reproduce the issue

with php error reporting at full go to administrator/index.php?option=com_joomlaupdate

Expected result

no errors or notices

Actual result

Notice: Trying to get property 'version' of non-object in C:\htdocs\cms4\administrator\components\com_joomlaupdate\Model\UpdateModel.php on line 1302

System information (as much as possible)

Additional comments

avatar brianteeman brianteeman - open - 29 Aug 2018
avatar joomla-cms-bot joomla-cms-bot - change - 29 Aug 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 29 Aug 2018
avatar brianteeman brianteeman - change - 29 Aug 2018
Labels Added: J4 Issue
Removed: ?
avatar brianteeman brianteeman - unlabeled - 29 Aug 2018
avatar brianteeman brianteeman - labeled - 29 Aug 2018
avatar franz-wohlkoenig franz-wohlkoenig - change - 29 Aug 2018
Status New Discussion
avatar franz-wohlkoenig franz-wohlkoenig - change - 29 Aug 2018
Category com_joomlaupdate
avatar zero-24
zero-24 - comment - 29 Aug 2018

Can you please update the manifest cache and check if that fixes the problem?

I'm not even sure if that works anyway. As the foreach is not done by reference and the $extension var is not used any more.

avatar alikon
alikon - comment - 29 Aug 2018

some extensions have "false/null" in the manifest_cache field of the #__extensions table like mod_submenu

avatar zero-24
zero-24 - comment - 29 Aug 2018

Yes that should be fixed by an update of the manifest cache (which should add that data). But I'm not sure what this code does at all as it seams to not have an effect as the $extensions is by value and not by ref ;)

avatar alikon
alikon - comment - 29 Aug 2018

not only that module doesn't exists at all (as a core module)
and yes i'm guessing the same, wtf getNonCoreExtensions() means in the com_joomlaupdate

avatar alikon
alikon - comment - 29 Aug 2018

ahh it was introduced by pre update check #17742

avatar alikon
alikon - comment - 29 Aug 2018

maybe even on 3.9

avatar zero-24
zero-24 - comment - 29 Aug 2018

No the pre update check was moved to 3.10

avatar alikon
alikon - comment - 30 Aug 2018

with #21927 no more able to replicate this issue on 4.0

avatar brianteeman brianteeman - change - 30 Aug 2018
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2018-08-30 19:16:13
Closed_By brianteeman
avatar brianteeman brianteeman - close - 30 Aug 2018
avatar zero-24
zero-24 - comment - 31 Aug 2018

hmm the code still looks unused and would error again when a component don't offer a version tag or is this just me wondering what this code does at all?

avatar alikon
alikon - comment - 31 Aug 2018

is the version tag in a xml manifest mandatory ?

avatar zero-24
zero-24 - comment - 31 Aug 2018

My point is this is code that is not doing anything at all but maybe it is just me. ;)

Add a Comment

Login with GitHub to post a comment