? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
28 Aug 2018

Pull Request for Issue #21889 .

Summary of Changes

fixed wrong written INNER JOIN

Testing Instructions

see #21889 and use PDO

Expected result

query are written in SQL standard

Actual result

query are written in mysql dialect

avatar alikon alikon - open - 28 Aug 2018
avatar alikon alikon - change - 28 Aug 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Aug 2018
Category Administration com_content
avatar alikon alikon - change - 28 Aug 2018
The description was changed
avatar alikon alikon - edited - 28 Aug 2018
avatar richard67
richard67 - comment - 28 Aug 2018

I have tested this item successfully on 4d0da93


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21893.

avatar richard67 richard67 - test_item - 28 Aug 2018 - Tested successfully
avatar richard67
richard67 - comment - 28 Aug 2018

There are code style errors though:

FILE: ...joomla-cms/administrator/components/com_content/Model/ArticlesModel.php

FOUND 2 ERROR(S) AFFECTING 2 LINE(S)

229 | ERROR | Opening parenthesis of a multi-line function call must be the last content on the line
248 | ERROR | Opening parenthesis of a multi-line function call must be the last content on the line


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21893.
avatar alikon
alikon - comment - 28 Aug 2018

grrr

avatar alikon alikon - change - 28 Aug 2018
Labels Added: ?
avatar richard67
richard67 - comment - 28 Aug 2018

I have tested this item successfully on 07dbc7e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21893.

avatar richard67 richard67 - test_item - 28 Aug 2018 - Tested successfully
avatar alikon
alikon - comment - 28 Aug 2018

well now drone failure is not up to this pr ?

avatar richard67
richard67 - comment - 28 Aug 2018

Yes, I saw. Some timeout on user creation.

avatar wilsonge wilsonge - close - 29 Aug 2018
avatar wilsonge wilsonge - merge - 29 Aug 2018
avatar wilsonge wilsonge - change - 29 Aug 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-08-29 10:35:01
Closed_By wilsonge

Add a Comment

Login with GitHub to post a comment