? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
27 Aug 2018

All new code is being forced to follow the codestyle and not to use $q or $qn

This pr updates all the remaining instances in core

code review

avatar brianteeman brianteeman - open - 27 Aug 2018
avatar brianteeman brianteeman - change - 27 Aug 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Aug 2018
Category Administration com_admin com_associations com_categories com_contact com_content com_fields com_finder com_installer com_joomlaupdate com_languages com_menus com_modules com_newsfeeds com_postinstall com_redirect com_templates com_users com_workflow CLI Front End
avatar zero-24
zero-24 - comment - 27 Aug 2018

Please also take a look into the drone issues now complain about too long lines?http://ci.joomla.org/joomla/joomla-cms/9419/8

Beyond that two points this looks fine for me! Thanks!

bae225a 27 Aug 2018 avatar brianteeman drone
avatar brianteeman brianteeman - change - 27 Aug 2018
Labels Added: ?
avatar wilsonge wilsonge - change - 28 Aug 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-08-28 23:10:56
Closed_By wilsonge
avatar wilsonge wilsonge - close - 28 Aug 2018
avatar wilsonge wilsonge - merge - 28 Aug 2018
avatar wilsonge
wilsonge - comment - 28 Aug 2018

Thanks!

avatar brianteeman
brianteeman - comment - 28 Aug 2018

With small steps we make big progress

Add a Comment

Login with GitHub to post a comment