[#21847] - [4.0] Fix broken iframe + modal + backdrop combination
- Fixed in Code Base
- 7 Sep 2018
- Medium
- Build: 4.0-dev
- # 21847
- Diff
- bembelimen:modal-iframe
User tests: Successful: Unsuccessful:
Pull Request for Issue #19408 .
Summary of Changes
Next try for fixing the broken modal and backdrop problem.
The problem (and difference to the article batch which uses the same button than the patchtester) is, that we're loading an IFrame in the modal and doing this, the button creates the modal directly after the button (HTML code). That leads to the fact, that with the position: fixed/relative + flex structure of the page the modal is behind the darkening backdrop background.
A quick solution here is to move the modal in this (and only this) special case just before the </body> tag, so there is no strange influence from the positioning.
Testing Instructions
See here: #21343 you can install the patchtester from here and test the "fetch data" modal.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Title |
|
||||||
I have tested this item
Welcome correction.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21847.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
| Status | Ready to Commit | ⇒ | Pending |
Status set back on "Pending".
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21847.
#21852 is closed now, so this patch here is ready to commit again...
I tested it too and it's working in every major browser.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21847.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
| Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-09-07 18:51:36 |
| Closed_By | ⇒ | wilsonge |
I have tested this item✅ successfully on c083216
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21847.