[#21840] - [4.0] Remove hard coded string in language errors display
- Fixed in Code Base
- 27 Aug 2018
- Medium
- Build: 4.0-dev
- # 21840
- Diff
- elkuku:hard-coded-lang-errors
User tests: Successful: Unsuccessful:
Summary of Changes
I was thinking on how to "sell" this to the "gate keepers" so I guess that I should start with
- Remove hard coded string in language errors display
The stringerror(s) in line(s)is hard coded and untranslatable.
On the other hand I believe that it should be the responsibility of the "caller" to format this message.
It will also be useful while refactoring the debug plugin in #20380
As a bonus the file links are now pointing to the error line if you have xdebug links set up.
Testing Instructions
Switch on language debug and produce some errors in language files
Expected result
Actual result
Documentation Changes Required
I believe that this is somewhat B/C breaking since the return values have changed - you might get an "array to string conversion" warning.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries Front End Plugins |
produce some errors in language files
How to produce an Error in an Language File?
How to produce an Error in an Language File?
Modify a file by for example taking off the first doublequote in
JSOMETHING="something"
Remove a " or an = on a line. That should be enough.
| Title |
|
||||||
thanks for Info, will do.
Changed Title to show its about 4.0.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21840.
Changed a File in Languages:
but get no Error:
Same Result if change Language-File in /administrator:
mod_breadcrumbs, after taking off the " edit the module in back-end (debug language on)
same for login
btw, the errors also show in frontend
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21840.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21840.
| Status | Pending | ⇒ | Ready to Commit |
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-08-27 09:40:40 |
| Closed_By | ⇒ | laoneo |
Ready to Commit after 3 successful tests.
Thanks.
I have tested this item✅ successfully on 140198b
Before applying the patch the faulty language entries are plain text and after applying the patch the language entries are clickable and take me to the correct file and line.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21840.