? ?
avatar brianteeman
brianteeman
23 Aug 2018

When you create a new workflow it automatically creates one new stage for published. I am not sure what the logic is behind this but its not very useful. Sure it means that you can create a new article ad this is the minimum required but it leads to confusion about why you cant delete or unpublish an article etc.

My thinking is that when you create a new workflow it automatically creates the "default" stages and transitions. This creates no extra work for the user. Instead of having to create them they just have to edit them (if required). The benefit is that you probably wont end up forgetting to create a delete stage or a transition to delete. etc

A quick test with the code in the save function in WorkflowModel seems to make it much easier to work with creating a new workflow.

Thoughts?

@bembelimen @wilsonge @HLeithner

avatar brianteeman brianteeman - open - 23 Aug 2018
avatar joomla-cms-bot joomla-cms-bot - change - 23 Aug 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 23 Aug 2018
avatar brianteeman brianteeman - change - 23 Aug 2018
Labels Added: ?
avatar brianteeman brianteeman - labeled - 23 Aug 2018
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 23 Aug 2018

when you create a new workflow it automatically creates the "default" stages and transitions

That would help and be "expected Behaviour".

avatar brianteeman brianteeman - change - 23 Aug 2018
Labels Added: J4 Issue
avatar brianteeman brianteeman - labeled - 23 Aug 2018
avatar HLeithner
HLeithner - comment - 23 Aug 2018

No sure if this is better then no entry, only "published" makes not much sense that's true.

A complete workflow example should be in sampledata plugin and if you create a new workflow it should be empty but both is ok for me.

avatar wilsonge
wilsonge - comment - 23 Aug 2018

when you create a new workflow it automatically creates the "default" stages and transitions

Depends what you mean by default :) I think that for new workflows unpublished has to be default. We also won't want the archived flow by default too I think.

avatar brianteeman
brianteeman - comment - 23 Aug 2018

By default I mean the same as currently created on install and called joomla default

Sampledata plugin is a different issue

avatar franz-wohlkoenig franz-wohlkoenig - change - 23 Aug 2018
Status New Discussion
avatar franz-wohlkoenig franz-wohlkoenig - change - 23 Aug 2018
Category com_workflow
avatar bembelimen
bembelimen - comment - 23 Aug 2018

The idea behind the published only stage was:
don't pollute the new workflow with potential unnecessary stages, because imho at the end the goal of each workflow is to publish/finish something. All other stages are optional. With a new workflow article are not automagical published without user interaction. So I'm not sure if we should add more than published to a new workflow (less is also not recommended, because then the workflow is broken)

avatar brianteeman
brianteeman - comment - 23 Aug 2018

With a new workflow article are not automagical published without user interaction

Sorry I don't understand that statement

avatar brianteeman
brianteeman - comment - 1 Sep 2018

This also has a benefit that if a user messes up their workflow (and given the opportunity they will) they can easily create a new fully working workflow

avatar franz-wohlkoenig franz-wohlkoenig - change - 2 Sep 2018
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2018-09-02 16:30:08
Closed_By franz-wohlkoenig
avatar joomla-cms-bot joomla-cms-bot - change - 2 Sep 2018
Closed_By franz-wohlkoenig joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 2 Sep 2018
avatar joomla-cms-bot
joomla-cms-bot - comment - 2 Sep 2018
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 2 Sep 2018

closed as having Pull Request #21963

avatar franz-wohlkoenig franz-wohlkoenig - change - 20 Apr 2019
Labels Added: ?
Removed: J4 Issue ?
avatar franz-wohlkoenig franz-wohlkoenig - unlabeled - 20 Apr 2019

Add a Comment

Login with GitHub to post a comment