? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
21 Aug 2018

Can be seen in the extensions install from web - changes from gray to white to add contrast and match style

Pull Request for Issue #21027

image .

avatar brianteeman brianteeman - open - 21 Aug 2018
avatar brianteeman brianteeman - change - 21 Aug 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Aug 2018
Category Administration Templates (admin) Installation Front End Templates (site)
9f252c0 21 Aug 2018 avatar brianteeman cs
avatar brianteeman brianteeman - change - 21 Aug 2018
Labels Added: ?
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 21 Aug 2018 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 21 Aug 2018

I have tested this item successfully on 9f252c0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21798.

avatar wilsonge wilsonge - change - 21 Aug 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-08-21 16:47:45
Closed_By wilsonge
avatar wilsonge wilsonge - close - 21 Aug 2018
avatar wilsonge wilsonge - merge - 21 Aug 2018
avatar infograf768
infograf768 - comment - 22 Aug 2018

@wilsonge or @laoneo
Can you please correct any PR touching compiled css files where we have the infamous ˆM windows EOL added where it should not. In this case here where npm on Windows has created them incorrectly?
https://github.com/joomla/joomla-cms/pull/21798/files#diff-a962cdc9935c244cac9994f2ca5100f2R9449

screen shot 2018-08-22 at 08 39 13

The only solution I see for now if to re-run npm install on core (from Linux or Macintosh) after merging such a PR.

avatar laoneo
laoneo - comment - 22 Aug 2018

Probably better to remove the template min files from github too.

avatar infograf768
infograf768 - comment - 22 Aug 2018

for this peculiar issue, the min files are compiled fine.
Otherwise I guess we are tending towards #21504 which means that patchtester users will not be able to test when changes in css.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 22 Aug 2018

patchtester users will not be able to test when changes in css.

which isn't relevant if testing Platform is coming up.

Add a Comment

Login with GitHub to post a comment