User tests: Successful: Unsuccessful:
Can be seen in the extensions install from web - changes from gray to white to add contrast and match style
Pull Request for Issue #21027
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Templates (admin) Installation Front End Templates (site) |
Labels |
Added:
?
|
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-08-21 16:47:45 |
Closed_By | ⇒ | wilsonge |
@wilsonge or @laoneo
Can you please correct any PR touching compiled css files where we have the infamous ˆM
windows EOL added where it should not. In this case here where npm on Windows has created them incorrectly?
https://github.com/joomla/joomla-cms/pull/21798/files#diff-a962cdc9935c244cac9994f2ca5100f2R9449
The only solution I see for now if to re-run npm install on core (from Linux or Macintosh) after merging such a PR.
Probably better to remove the template min files from github too.
patchtester users will not be able to test when changes in css.
which isn't relevant if testing Platform is coming up.
I have tested this item✅ successfully on 9f252c0
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21798.