? Pending

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
20 Aug 2018

Running npm install nets me this two changed files.
One is due to an updated TinyMCE where the plugin manifest wasn't updated as well.
The package.lock I barely understand.

Summary of Changes

Updates the files changed by running npm install so Git doesn't complain anymore.

Testing Instructions

Code review

Expected result

Git has no changed files after running npm install

Actual result

Two files are marked as changed.

Documentation Changes Required

None

avatar Bakual Bakual - open - 20 Aug 2018
avatar Bakual Bakual - change - 20 Aug 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Aug 2018
Category Front End Plugins
avatar infograf768
infograf768 - comment - 21 Aug 2018

I guess can be merged directly.

avatar laoneo laoneo - close - 21 Aug 2018
avatar laoneo laoneo - merge - 21 Aug 2018
avatar laoneo laoneo - change - 21 Aug 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-08-21 05:25:27
Closed_By laoneo
Labels Added: ?
avatar laoneo
laoneo - comment - 21 Aug 2018

Thanks

avatar wojsmol
wojsmol - comment - 21 Aug 2018

@Bakual Which node and npm version are you using and o which OS? I ask because I revive different package-lock.json.

avatar Bakual
Bakual - comment - 21 Aug 2018

This PR was done on Windows 10 with npm 5.6.0 on Node 8.11.3.
I had the same issue on a Linux box (similar version I think)

avatar Bakual
Bakual - comment - 21 Aug 2018

If we get a different outcome on different machines and node/npm versions, then I'm seriously confused as I'd expect the lock file to be the same on each enviroment, because that's the purpose of a lock file, right?

avatar wojsmol
wojsmol - comment - 21 Aug 2018

Here is my package-lock.json

node --version
v8.9.4
npm --version
6.4.0
avatar mbabker
mbabker - comment - 21 Aug 2018

See https://stackoverflow.com/questions/47638381/what-did-package-lock-json-change-the-integrity-hash-from-sha1-to-sha512 for some context on integrity hashes and why those can change between environments.

Your changes in this PR look to be a variant of npm/npm#20434

Loosely similar is https://npm.community/t/package-lock-json-keeps-changing-between-platforms-and-runs/1129 and https://npm.community/t/package-lock-json-changes-from-one-npm-install-to-the-next/1454

Long and short is whatever the problem is is within NPM itself, worsened by the fact we have a community that is running a massively wide range of versions of software which apparently all have different behaviors.

avatar wojsmol
wojsmol - comment - 21 Aug 2018

@mbabker @dgrammatiko Any ideas for this? We must have a method to produce consistent package-lock.json.

avatar Bakual
Bakual - comment - 21 Aug 2018

So npm is unreliable in building a reproducable enviroment. Doesn't sound that great.
If I understood the links correct, the behavior is fixed in npm v6? Making that a requirement?
Or do we have to change the installation doc so npm ci (npm v5.7.0+) is used which works directly from the lock file?

avatar wojsmol
wojsmol - comment - 21 Aug 2018

We can add npm as a dev dependency and then use local install instead of global.

Add a Comment

Login with GitHub to post a comment