? ?
avatar brianteeman
brianteeman
20 Aug 2018

Just wondering what people think about changing the name of the status of a workflow/stage/transition to enabled/disabled/trashed instead of published/unpublished/trashed

Current
chrome_2018-08-20_10-00-07

Suggestion
chrome_2018-08-20_10-00-35

avatar brianteeman brianteeman - open - 20 Aug 2018
avatar joomla-cms-bot joomla-cms-bot - change - 20 Aug 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 20 Aug 2018
avatar brianteeman brianteeman - change - 20 Aug 2018
Labels Added: J4 Issue
avatar brianteeman brianteeman - labeled - 20 Aug 2018
avatar brianteeman brianteeman - change - 20 Aug 2018
Labels Added: ?
avatar brianteeman brianteeman - labeled - 20 Aug 2018
avatar bembelimen
bembelimen - comment - 20 Aug 2018

Yes, please, good idea!

Perhaps we also get rid of the word "status"?

avatar brianteeman
brianteeman - comment - 20 Aug 2018

Yes, please, good idea!

PR will be created

Perhaps we also get rid of the word "status"?

I did think about that but even in plugins where we says enabled/disabled we still label it as status

avatar brianteeman
brianteeman - comment - 20 Aug 2018

ah - wait, just realised that in com_plugins we just have enabled/disabled but here you have published/unpublished/trashed :( So to switch to just two is a bigger issue

Also while looking at the xml files I see that stage and workflow both have permissions defined in the xml but i dont see them being used anywhere??

avatar infograf768
infograf768 - comment - 20 Aug 2018

Also, we do use enable/disable for extensions manager in general.
For this and plugins it makes totally sense.
I would not change the wording elsewhere because of workgroup.

avatar franz-wohlkoenig franz-wohlkoenig - change - 20 Aug 2018
Status New Discussion
avatar franz-wohlkoenig franz-wohlkoenig - change - 20 Aug 2018
Category com_workflow
avatar brianteeman
brianteeman - comment - 20 Aug 2018

For this and plugins it makes totally sense.

Obviously thats what I thought originally too but as there are 3 options it would require bigger changes to workflows than just changing the xml to make it just 2

I would not change the wording elsewhere because of workgroup.

I wasn't suggesting changing anything anywhere else - not sure where you got that idea

avatar franz-wohlkoenig franz-wohlkoenig - change - 21 Aug 2018
Title
Workflow - status enabled not published
[4.0] Workflow - status enabled not published
avatar joomla-cms-bot joomla-cms-bot - edited - 21 Aug 2018
avatar bembelimen
bembelimen - comment - 23 Aug 2018

Why should "enabled", "disabled" and "trashed" as tripple not work? Perhaps I didn't understand the context?

avatar brianteeman
brianteeman - comment - 23 Aug 2018

a triple is possible

avatar bembelimen
bembelimen - comment - 23 Aug 2018

I really like enabled/disabled and didn't get the problem here, hence the question.

avatar brianteeman
brianteeman - comment - 23 Aug 2018

The "problem" is that elsewhere that we have enabled/disabled we do not also have trashed. So its an inconsistency to have it as a triple here. But I can create the PR with the triple and leave it for others to decide

avatar brianteeman brianteeman - change - 24 Aug 2018
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2018-08-24 15:23:50
Closed_By brianteeman
avatar brianteeman brianteeman - close - 24 Aug 2018
avatar brianteeman
brianteeman - comment - 24 Aug 2018

Closed see #21836

avatar franz-wohlkoenig franz-wohlkoenig - change - 20 Apr 2019
Labels Added: ?
Removed: J4 Issue ?
avatar franz-wohlkoenig franz-wohlkoenig - unlabeled - 20 Apr 2019

Add a Comment

Login with GitHub to post a comment