?
avatar PhilETaylor
PhilETaylor
19 Aug 2018

Steps to reproduce the issue

Surely if a version of an article is set to "keep forever" = yes, then I should not be able to delete it?

Expected result

That I should have to toggle the keep forever to be no before I can delete a version of an article

Actual result

if keep forever is enabled, I can still delete the version in the popup on the frontend.
screen shot 2018-08-19 at 22 44 53

System information (as much as possible)

5defb00

avatar PhilETaylor PhilETaylor - open - 19 Aug 2018
avatar joomla-cms-bot joomla-cms-bot - change - 19 Aug 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 19 Aug 2018
avatar dgrammatiko
dgrammatiko - comment - 19 Aug 2018

Out of curiosity is J3 different here?

avatar PhilETaylor
PhilETaylor - comment - 19 Aug 2018

No idea. Ain't no body got time for Joomla 3 anymore. If issues are not marked with a "4" tag no one cares ;-)

avatar mbabker
mbabker - comment - 19 Aug 2018

Maybe that's why I can't get 3.9 out the door :trollface:

avatar PhilETaylor
PhilETaylor - comment - 19 Aug 2018

I thought we were skipping Joomla 3.9? :trollface:

avatar ggppdk
ggppdk - comment - 19 Aug 2018

@PhilETaylor
you had a similar issue for J3

Behavior of J3 was "corrected" or modified (depends on how you feel about fixing this) on June 18
7a33abe

avatar PhilETaylor
PhilETaylor - comment - 19 Aug 2018

did I - wow - well shows that I test repeatedly then, and that even though it appears that a PR was made - the issue is still there today....

avatar PhilETaylor
PhilETaylor - comment - 19 Aug 2018

Well it doesnt appear (at first glance) to have been ported to the Joomla 4 code - see https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_contenthistory/Model/HistoryModel.php and therefore this is still a valid issue

avatar ggppdk
ggppdk - comment - 19 Aug 2018

It is not easy task to move some of these changes to J4 branch, it must be a pain

avatar PhilETaylor
PhilETaylor - comment - 19 Aug 2018

Yes its a pain, but I thought the whole point of making PR's against 3 was that they would be eventually rolled into 4 - else all that 4 is, is a fork of an old version of 3 and missing a LOT of fixes that were applied to 3 - including security fixes :trollface:!

avatar franz-wohlkoenig franz-wohlkoenig - change - 20 Aug 2018
Status New Discussion
avatar franz-wohlkoenig franz-wohlkoenig - change - 20 Aug 2018
Category com_contenthistory
avatar brianteeman
brianteeman - comment - 20 Aug 2018

They are eventually being rolled into j4 - its a long and complex job - not something that can be done blindly.

avatar brianteeman brianteeman - change - 20 Aug 2018
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2018-08-20 07:24:38
Closed_By brianteeman
avatar brianteeman brianteeman - close - 20 Aug 2018
avatar PhilETaylor
PhilETaylor - comment - 23 Oct 2018

This is still an issue in Joomla 4.0-dev @ 9d3acfd today

Add a Comment

Login with GitHub to post a comment