Feeling Lucky
?
[#21734] - HTMLHelper stylesheet method
- Closed
- 8 Nov 2018
- Medium
- Build: staging
- # 21734
- Diff
- brianteeman:foto
User tests: Successful: Unsuccessful:
Pull Request for Issue #21216 .
Summary of Changes
In ./libraries/src/HTML/HTMLHelper.php at line 610 it writes:
if (!is_array($attribs))
but should better be
if (!is_array($attribs) || !is_array($options))
Reason
An old extension adding stylesheets the (very) old way like
JHTML::stylesheet('filename','path-to-file');
will obviously not add the stylesheet but still create several "illegal string offset" notices instead of better eventually add a deprecated message to flog
(this is a recreation of a pr from @FoTo50 which went wrong
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-11-08 13:18:21 |
| Closed_By | ⇒ | brianteeman | |
| Labels |
Added:
?
|
||