? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
19 Aug 2018

Pull Request for Issue #21727

Summary of Changes

font-weight: normal ===> 400
font-weight: bold ===> 700

As per https://developer.mozilla.org/en-US/docs/Web/CSS/font-weight

avatar brianteeman brianteeman - open - 19 Aug 2018
avatar brianteeman brianteeman - change - 19 Aug 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Aug 2018
Category Administration com_media Templates (admin) Repository Front End Templates (site)
avatar brianteeman brianteeman - change - 19 Aug 2018
Labels Added: ?
avatar C-Lodder
C-Lodder - comment - 19 Aug 2018

I still think defining an array of font weight values in an array in variables.scss would be better, but whatever you guys prefer.

Primarily because I noticed in a recent project of mine that the bold font wasn't 700 like it normally is, but was 500.

avatar brianteeman
brianteeman - comment - 19 Aug 2018

Would have helped if you had expressed that view in your issue ;)

I just went for the standards

avatar C-Lodder
C-Lodder - comment - 19 Aug 2018

@brianteeman I clearly stated in my issue:

An array of font weights should be defined in the variables.scss with all the possible numeric keywords.

avatar C-Lodder
C-Lodder - comment - 19 Aug 2018

Don't get me wrong, this is better than before but could still be a little more dynamic

avatar brianteeman
brianteeman - comment - 19 Aug 2018

apologies - i must have missed it - feel free to submit your own pr for this issue if you wish

38f9270 24 Aug 2018 avatar brianteeman bold
78ec12b 24 Aug 2018 avatar brianteeman hound
avatar brianteeman
brianteeman - comment - 24 Aug 2018

conflicts resolved

avatar webgras
webgras - comment - 8 Sep 2018

we tried to test during PBF18.

What we tested:
check file administrator/templates/atum/css/template.css

Result:
There is still
h1,
h2,
h3,
h4,
h5,
h6 {
font-weight: bold; }

h1 {
font-weight: normal; }

also in administrator/templates/atum/css/template.min.css
however, we did not find where it comes from.

avatar webgras
webgras - comment - 8 Sep 2018

yes, we just did build:css again - it is till with "bold" and "normal" there

avatar lavipr
lavipr - comment - 8 Sep 2018

I have tested this item successfully on 78ec12b

Testing steps:

avatar lavipr lavipr - test_item - 8 Sep 2018 - Tested successfully
avatar brianteeman
brianteeman - comment - 8 Sep 2018

Don't know what I can tell you

image

avatar HLeithner
HLeithner - comment - 8 Sep 2018

I have tested this item successfully on 78ec12b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21731.

avatar HLeithner HLeithner - test_item - 8 Sep 2018 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 8 Sep 2018
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 8 Sep 2018

Ready to Commit after two successful tests.

avatar laoneo
laoneo - comment - 20 Sep 2018

Can you fix conflicts here please?

avatar brianteeman
brianteeman - comment - 20 Sep 2018

I am not sure it is correct any more based on the comments above by @C-Lodder and the recent changes that @wilsonge has committed directly with CSS vars

avatar wilsonge wilsonge - change - 20 Sep 2018
Labels Added: ?
avatar wilsonge
wilsonge - comment - 20 Sep 2018

I don't think CSS vars has any issues with this. I'd stick with using CSS vars for breakpoints and colours for now - we don't need every single variable to be exposed to users. Fixed conflicts too. If you can do Charlie's solution that would be good though

avatar brianteeman
brianteeman - comment - 20 Sep 2018

I am happy to go with any solution - if you want me to go with Charlie's approach I will do that at the weekend when I am at the sprint

avatar brianteeman
brianteeman - comment - 21 Sep 2018
avatar brianteeman
brianteeman - comment - 21 Sep 2018

but named correctly to match the spec https://www.w3.org/TR/css-fonts-3/#propdef-font-weight

avatar brianteeman
brianteeman - comment - 21 Sep 2018

closed see #22317

avatar brianteeman brianteeman - close - 21 Sep 2018
avatar brianteeman brianteeman - change - 21 Sep 2018
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2018-09-21 23:50:42
Closed_By brianteeman

Add a Comment

Login with GitHub to post a comment