? ? Success

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
8 Oct 2013
avatar wilsonge wilsonge - open - 8 Oct 2013
avatar brianteeman
brianteeman - comment - 13 Oct 2013

Please can you create a joomlacode tracker item to correspond to this - thanks

avatar wilsonge
wilsonge - comment - 13 Oct 2013

Updated with the tracker. However note this is just an implementation of a feature - it probably isn't going to be merged in as is

avatar brianteeman
brianteeman - comment - 13 Oct 2013

So why is it here? Shouldnt it be on your own github account?

avatar wilsonge
wilsonge - comment - 13 Oct 2013

It's for people to use for testing. As my Feature PR has no visable effects. It makes it easier for non-coders to test the feature in patchtester

avatar brianteeman brianteeman - change - 21 Aug 2014
Status New Pending
Build .
avatar brianteeman brianteeman - change - 2 Sep 2014
Category Layout
avatar RCheesley RCheesley - test_item - 18 Oct 2014 - Tested successfully
avatar RCheesley
RCheesley - comment - 18 Oct 2014

Successful tests, I have some suggestions for improvement:

  1. Users may wish to disable the social icons for specific categories or menu items but I don't see an option to change this on the category, only the individual item itself.

  2. Is it possible to give different display options globally - example https://about.twitter.com/resources/buttons, https://developers.facebook.com/docs/plugins/like-button/, https://developers.google.com/+/web/+1button/

    This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/2173.

avatar RCheesley
RCheesley - comment - 18 Oct 2014

Also, whether to show top or bottom of the article?

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/2173.

avatar wilsonge wilsonge - change - 18 Oct 2014
Title
Use the Social JLayouts in com_content as an example
[#31516] Use the Social JLayouts in com_content as an example
avatar mtmeyrick mtmeyrick - test_item - 19 Oct 2014 - Tested successfully
avatar roland-d
roland-d - comment - 28 Nov 2014

@wilsonge Is this going anywhere? How about the suggestions by @RCheesley ?

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/2173.

avatar wilsonge
wilsonge - comment - 28 Nov 2014

As I stated above in the description and below in the comments. This was just a feature implementation to allow testing of the layouts in #1550.

avatar roland-d
roland-d - comment - 29 Nov 2014

@test: Fails, I get the following error viewing the frontpage article:
Parse error: syntax error, unexpected '[' in D:\wamp\www\joomla-cms\layouts\social\facebook.php on line 64

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/2173.

avatar roland-d roland-d - test_item - 29 Nov 2014 - Tested unsuccessfully
avatar wilsonge
wilsonge - comment - 29 Nov 2014

Please see #5253 which is against staging instead of master but is otherwise a direct duplicate. Closing this one.

avatar wilsonge wilsonge - close - 29 Nov 2014
avatar wilsonge wilsonge - change - 29 Nov 2014
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2014-11-29 23:01:58

Add a Comment

Login with GitHub to post a comment