PR-4.0-dev RTC

Pending

User tests: Successful: Unsuccessful:

avatar chmst
chmst
19 Aug 2018

JAT has found several a11y issues in the SystemInformation View:

This PR replaces #21628 which I have deleted - my mistake. Could someone please close the old PR? Sorry for inconvenience.

Summary of Changes

Remove the < form > tag, as this is not a form.
Remove empty Table Footers
Replace the < fieldset > Tag by < div >
Remove the < legend > by Table < caption >
Improve the Table header with some css, add a new scss file for com_admin

avatar chmst chmst - open - 19 Aug 2018
avatar chmst chmst - change - 19 Aug 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Aug 2018
Category Administration com_admin Templates (admin)
avatar chmst chmst - change - 19 Aug 2018
Title
Replace PR 21628 - improve a11y for systeminformation
[4.0] Improve a11y for systeminformation
avatar chmst chmst - edited - 19 Aug 2018
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 19 Aug 2018

#21628 is closed as requested.

avatar brianteeman
brianteeman - comment - 19 Aug 2018

Looks good - can you fix hound please

avatar wojsmol
wojsmol - comment - 19 Aug 2018

Additionally we have a merge conflict in this files:

administrator/templates/atum/css/template-rtl.min.css
administrator/templates/atum/css/template.min.css 
avatar chmst chmst - change - 20 Aug 2018
Labels Added: PR-4.0-dev
avatar chmst
chmst - comment - 20 Aug 2018

@wojsmol can you help me? I don't know how to resolve conflicts in .min.css files.

avatar wojsmol
wojsmol - comment - 20 Aug 2018
avatar joomla-cms-bot joomla-cms-bot - change - 20 Aug 2018
Category Administration com_admin Templates (admin) Administration com_admin com_media Templates (admin) Front End Plugins
avatar wojsmol
wojsmol - comment - 20 Aug 2018

@chmst I send PR reverting my last changes.

avatar chmst
chmst - comment - 20 Aug 2018

All right. I don't understand the conflicts, because the .css and min.css files should be generated from the scss files.

avatar wojsmol
wojsmol - comment - 20 Aug 2018

accept my last PR then I prepare good one.

avatar joomla-cms-bot joomla-cms-bot - change - 20 Aug 2018
Category Administration com_admin Templates (admin) com_media Front End Plugins Administration com_admin Templates (admin)
avatar chmst
chmst - comment - 20 Aug 2018

It is merged. Is there something else I have to do?

avatar wojsmol
wojsmol - comment - 20 Aug 2018
avatar joomla-cms-bot joomla-cms-bot - change - 22 Aug 2018
Category Administration com_admin Templates (admin) Administration com_admin com_media Templates (admin) Language & Strings Installation Front End Plugins
avatar wojsmol
wojsmol - comment - 3 Sep 2018

@chmst All conflicting css files can be deleted from this PR because they are added to .gitignore in the current 4.0-dev. Additionally please delete following files and folders

administrator/templates/atum/html/com_patchtester_meins
nbproject
administrator/components/com_media/package-lock.json
avatar chmst chmst - change - 3 Sep 2018
Labels Added: Language Change
avatar chmst
chmst - comment - 3 Sep 2018

cannot find dthe package-lock.json any more.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21724.

avatar chmst
chmst - comment - 3 Sep 2018

cannot find dthe package-lock.json any more.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21724.

avatar wojsmol
wojsmol - comment - 3 Sep 2018

Ok, then we have following conflicting files list

administrator/components/com_admin/tmpl/sysinfo/default.php
administrator/templates/atum/css/bootstrap.css
administrator/templates/atum/css/bootstrap.min.css
administrator/templates/atum/css/template-rtl.css
administrator/templates/atum/css/template-rtl.min.css
administrator/templates/atum/css/template.css
administrator/templates/atum/css/template.min.css
installation/template/css/template.css
installation/template/css/template.min.css

see my previous comment #21724 (comment)

avatar wojsmol
wojsmol - comment - 4 Sep 2018

@chmst If you need any help then simply write

avatar chmst
chmst - comment - 4 Sep 2018

I'm trying right now, but cannot reproduce the branch. I had done the npm for testing other pr's.

avatar chmst
chmst - comment - 4 Sep 2018

@wojsmol I cannot reproduce the conflicts in my repo. The simple way sowud be to close this pr and make a new one?

avatar wojsmol
wojsmol - comment - 4 Sep 2018

Simply merge 4.0-dev from joomla/joomla-cms into this PR branch. Then you revise conflicts.

avatar wojsmol
wojsmol - comment - 4 Sep 2018

@chmst Please see chmst#4

avatar wojsmol
wojsmol - comment - 4 Sep 2018

@chmst I must miss same changes in administrator/components/com_admin/tmpl/sysinfo/default.php. Please compare with https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_admin/tmpl/sysinfo/default.php

avatar chmst
chmst - comment - 4 Sep 2018

@wojsmol - Thank you, I will resolve this when I am back home. The < form > tag is not needed.

avatar joomla-cms-bot joomla-cms-bot - change - 4 Sep 2018
Category Administration com_admin Templates (admin) com_media Language & Strings Installation Front End Plugins Administration com_admin com_media Templates (admin)
avatar chmst
chmst - comment - 4 Sep 2018

@wojsmol hope that the conflict is resolved now. Thank you for your patience

avatar baernm
baernm - comment - 8 Sep 2018

I have tested this item successfully on cd203ad


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21724.

avatar baernm
baernm - comment - 8 Sep 2018

I have tested this item successfully on cd203ad


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21724.

avatar baernm baernm - test_item - 8 Sep 2018 - Tested successfully
avatar wojsmol
wojsmol - comment - 8 Sep 2018

@chmst Please remove administrator/components/com_media/package-lock.json from this PR.

avatar chmst chmst - change - 9 Sep 2018
Labels Removed: Language Change
avatar joomla-cms-bot joomla-cms-bot - change - 9 Sep 2018
Category Administration com_admin Templates (admin) com_media Administration com_admin Templates (admin)
avatar laoneo
laoneo - comment - 18 Oct 2018

@brianteeman all ok here from your side?

avatar brianteeman
brianteeman - comment - 18 Oct 2018

@laoneo it was good when I first checked it - not sure if there have been significant changes since

avatar laoneo
laoneo - comment - 18 Oct 2018

Do you mind to have another look?

avatar chmst
chmst - comment - 18 Oct 2018

Wait a moment. There is another PR which has changed something in the library. I can resolve this as soon as the other change is merged.

avatar brianteeman
brianteeman - comment - 18 Oct 2018

@laoneo I will put it on my todo for tonight

avatar carcam
carcam - comment - 23 Nov 2018

I have tested this item successfully on cf368e5

I have tested this change in Joomla 4 Alpha 5 release succesfully. There are no visible differences in the View System Information before and after patch.

I have also tested with Wave Automatic Test and I got the error of an empty th which belongs to the php info about mysqlnd statistics which was empty in my server but I do not think it's related with this PR.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21724.

avatar carcam carcam - test_item - 23 Nov 2018 - Tested successfully
avatar chmst
chmst - comment - 23 Nov 2018

@carcam thank you for testing. And good finding of the empty in the php-info. Let's make another PR for the sysinfo model, to avoid empty table headers.

avatar Quy Quy - change - 23 Nov 2018
Status Pending Ready to Commit
avatar Quy
Quy - comment - 23 Nov 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21724.

avatar zwiastunsw
zwiastunsw - comment - 23 Nov 2018

I tested this patch. Fieldset and legend elements have been rightly removed. But...
The "caption" element should be used in the table instead of the legend element. Without the caption element, users of screen readers will not get the information contained in the table.

avatar laoneo laoneo - change - 24 Nov 2018
Labels Added: RTC

Add a Comment

Login with GitHub to post a comment