User tests: Successful: Unsuccessful:
JAT has found several a11y issues in the SystemInformation View:
This PR replaces #21628 which I have deleted - my mistake. Could someone please close the old PR? Sorry for inconvenience.
Remove the < form > tag, as this is not a form.
Remove empty Table Footers
Replace the < fieldset > Tag by < div >
Remove the < legend > by Table < caption >
Improve the Table header with some css, add a new scss file for com_admin
|Category||⇒||Administration com_admin Templates (admin)|
Additionally we have a merge conflict in this files:
|Category||Administration com_admin Templates (admin)||⇒||Administration com_admin com_media Templates (admin) Front End Plugins|
All right. I don't understand the conflicts, because the .css and min.css files should be generated from the scss files.
|Category||Administration com_admin Templates (admin) com_media Front End Plugins||⇒||Administration com_admin Templates (admin)|
|Category||Administration com_admin Templates (admin)||⇒||Administration com_admin com_media Templates (admin) Language & Strings Installation Front End Plugins|
@chmst All conflicting css files can be deleted from this PR because they are added to .gitignore in the current 4.0-dev. Additionally please delete following files and folders
administrator/templates/atum/html/com_patchtester_meins nbproject administrator/components/com_media/package-lock.json
Ok, then we have following conflicting files list
administrator/components/com_admin/tmpl/sysinfo/default.php administrator/templates/atum/css/bootstrap.css administrator/templates/atum/css/bootstrap.min.css administrator/templates/atum/css/template-rtl.css administrator/templates/atum/css/template-rtl.min.css administrator/templates/atum/css/template.css administrator/templates/atum/css/template.min.css installation/template/css/template.css installation/template/css/template.min.css
see my previous comment #21724 (comment)
I'm trying right now, but cannot reproduce the branch. I had done the npm for testing other pr's.
Simply merge 4.0-dev from joomla/joomla-cms into this PR branch. Then you revise conflicts.
@chmst I must miss same changes in
administrator/components/com_admin/tmpl/sysinfo/default.php. Please compare with https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_admin/tmpl/sysinfo/default.php
|Category||Administration com_admin Templates (admin) com_media Language & Strings Installation Front End Plugins||⇒||Administration com_admin com_media Templates (admin)|
|Category||Administration com_admin Templates (admin) com_media||⇒||Administration com_admin Templates (admin)|
Wait a moment. There is another PR which has changed something in the library. I can resolve this as soon as the other change is merged.
I have tested this item
I have tested this change in Joomla 4 Alpha 5 release succesfully. There are no visible differences in the View System Information before and after patch.
I have also tested with Wave Automatic Test and I got the error of an empty th which belongs to the php info about mysqlnd statistics which was empty in my server but I do not think it's related with this PR.
|Status||Pending||⇒||Ready to Commit|
I tested this patch. Fieldset and legend elements have been rightly removed. But...
The "caption" element should be used in the table instead of the legend element. Without the caption element, users of screen readers will not get the information contained in the table.
|Status||Ready to Commit||⇒||Fixed in Code Base|
|Closed_Date||0000-00-00 00:00:00||⇒||2018-12-18 20:57:22|