? ? Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
19 Aug 2018

Pull Request for Issue #14163 .

Summary of Changes

Uses the menu item id when calculating the open search url. i have no clue if this is a good fix or not :D

For testing instructions see original issue

avatar wilsonge wilsonge - open - 19 Aug 2018
avatar wilsonge wilsonge - change - 19 Aug 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Aug 2018
Category Modules Front End
avatar wilsonge wilsonge - change - 19 Aug 2018
Labels Added: ?
avatar AndySDH
AndySDH - comment - 19 Aug 2018

Tested this, but doesn't work as it is:

JRoute::_('&option=com_search&format=opensearch&itemId=' . $mitemid), 'search', 'rel',

needs to be changed to:

JRoute::_('&option=com_search&format=opensearch&Itemid=' . $mitemid), 'search', 'rel',

avatar wilsonge
wilsonge - comment - 19 Aug 2018

I think I already fixed that 10 minutes ago :P

avatar AndySDH
AndySDH - comment - 19 Aug 2018

Oh nice! Great, it works with that fix :)

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 19 Aug 2018

@AndySDH please mark your Test as successfully:

  • open Issue Tracker
  • Login with your github-Account
  • Click on blue "Test this"-Button above Authors-Picture
  • mark your Test as successfully
  • hit "submit test result"
avatar AndySDH
AndySDH - comment - 19 Aug 2018

I have tested this item successfully on d0ef52b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21713.

avatar AndySDH AndySDH - test_item - 19 Aug 2018 - Tested successfully
avatar brianteeman brianteeman - test_item - 19 Aug 2018 - Tested successfully
avatar brianteeman
brianteeman - comment - 19 Aug 2018

I have tested this item successfully on d0ef52b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21713.

avatar franz-wohlkoenig franz-wohlkoenig - change - 19 Aug 2018
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 19 Aug 2018

Ready to Commit after two successful tests.

avatar mbabker mbabker - change - 21 Aug 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-08-21 03:50:52
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 21 Aug 2018
avatar mbabker mbabker - merge - 21 Aug 2018

Add a Comment

Login with GitHub to post a comment