? ? Pending

User tests: Successful: Unsuccessful:

avatar bembelimen
bembelimen
19 Aug 2018

Pull Request for Issue #21542 .

Summary of Changes

Readd the "All" filter to the condition filter in article view.

Testing Instructions

Open articles list view and filter by condition => all

avatar bembelimen bembelimen - open - 19 Aug 2018
avatar bembelimen bembelimen - change - 19 Aug 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Aug 2018
Category Administration com_content Libraries
avatar bembelimen bembelimen - change - 19 Aug 2018
Labels Added: ?
avatar franz-wohlkoenig franz-wohlkoenig - change - 19 Aug 2018
Title
Add show all articles filter
[4.0] Add show all articles filter
avatar joomla-cms-bot joomla-cms-bot - edited - 19 Aug 2018
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 19 Aug 2018

changed Title to show its about 4.0.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21704.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 19 Aug 2018

Tried to apply Pull Request per Patchtester get The file marked for modification does not exist: libraries/src/Form/Field/WorkflowconditionField.php

avatar wojsmol
wojsmol - comment - 19 Aug 2018

@franz-wohlkoenig check if your Joomla! installation is updated.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 19 Aug 2018

Its the nightly Build.

avatar wojsmol
wojsmol - comment - 19 Aug 2018

Then something is wrong - this file was created 2 days ago with #21585 merge

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 19 Aug 2018

i install every Dav new at CloudAccess (launch.joomla.org).

avatar wojsmol
wojsmol - comment - 19 Aug 2018

I will check now on my CA account.

avatar wojsmol
wojsmol - comment - 19 Aug 2018

@franz-wohlkoenig Because I don't have passibility to reset my Joomla! 4.0 on CA to 4.0 only to 3.8 I reinstalled it manually and then patch works as expected. using patch tester

avatar wojsmol wojsmol - test_item - 19 Aug 2018 - Tested successfully
avatar wojsmol
wojsmol - comment - 19 Aug 2018

I have tested this item successfully on 21afaa4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21704.

avatar ggppdk ggppdk - test_item - 19 Aug 2018 - Tested successfully
avatar ggppdk
ggppdk - comment - 19 Aug 2018

I have tested this item successfully on 21afaa4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21704.

avatar wojsmol
wojsmol - comment - 19 Aug 2018

@franz-wohlkoenig Do you have passibility to reset to Joomla! 4.0 nightly here or you just terminating old account and create new one?

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 19 Aug 2018

Reset didn't work as you can only 3.* reset. So i'm terminating Site and launch new using same URL.

avatar franz-wohlkoenig franz-wohlkoenig - change - 19 Aug 2018
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 19 Aug 2018

Ready to Commit after two successful tests.

37d5382 19 Aug 2018 avatar wilsonge PHPCS
avatar wilsonge wilsonge - change - 19 Aug 2018
Labels Added: ?
avatar wilsonge wilsonge - change - 19 Aug 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-08-19 10:10:57
Closed_By wilsonge
avatar wilsonge wilsonge - close - 19 Aug 2018
avatar wilsonge wilsonge - merge - 19 Aug 2018
avatar wilsonge
wilsonge - comment - 19 Aug 2018

Thanks!

Add a Comment

Login with GitHub to post a comment