[#21695] - Use search tools in the overrides view
- Fixed in Code Base
- 3 Sep 2018
- Medium
- Build: staging
- # 21695
- Diff
- wilsonge:fix/overrides-searchtools
User tests: Successful: Unsuccessful:
Pull Request for Issue #11976 .
Summary of Changes
Moves the overrides view to use search tools
Known Bug that needs solving before this is merged
I can't seem to get the session to persist the client across into the edit view - so it always uses the default (administrator) - filter by english admin then create a new overrides and the client is site not admin. @mbabker would appreciate some help cause I'm sure i'm doing something crazy dumb in the session
Testing Instructions
After patch we have search tools instead of the filtering in the sidebar
Documentation Changes Required
help screens
//cc @infograf768
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_languages |
That PR removes the sidebar from com_content. This is just moving the search functionality into searchtools in com_languages overrides. There's literally no common code between these two prs?
@dgrammatiko well for a start this PR is for Joomla 3 and the one you link to is for Joomla 4
| Labels |
Added:
?
|
||
and that one is doing extra things and is closed ;)
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21695.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21695.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-09-03 17:14:42 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
Sorry to say but I am not so happy with this
One has to click on search tools to define for which language and site or admin to make the override.
It will always default to the alpha order of the language (and site) if not selected through searchTools.
We have to find a better solution imho.
EDIT: I mean we may still use searchtools to filter (although we need a solution to display all overrides), but we need a specific field separated from SearchTools to select to which language and client we want to create a new override
Like the one in modules to select site or admin ??
Similar, yes. Rather like in menu items manager for Select Menu.
Basically, this means, if we want to do this right, some changes for the creation/editing of a new override as it is there imho that the language/client has normally to be selected, as we do for menu items where the Menu, if not already selected in the filter, has to be selected in the menu field
or also in com_associations
Should be easy enough - but as this has been merged please open a new issue for it
Not so easy.
@wilsonge why don't you just merge #19552 or the other PR? I think he already patched this there