[#21691] - Change language debug mode to allow it to show the language constants
- Fixed in Code Base
- 8 Sep 2018
- Medium
- Build: staging
- # 21691
- Diff
- brianteeman:debug-lang
User tests: Successful: Unsuccessful:
PR for #14304
By default there is no change when debug language is enabled - but there now is an option to display either the language constant or the language value
Arguably a new feature - I will let the maintainer decide on that
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_config Language & Strings Installation Libraries |
| Labels |
Added:
?
?
|
||
| Category | Administration com_config Language & Strings Installation Libraries | ⇒ | Administration com_config Language & Strings Installation Layout Libraries JavaScript |
| Category | Administration com_config Language & Strings Installation Libraries Layout JavaScript | ⇒ | Administration com_config Language & Strings Installation Libraries |
May I politely ask a question here.. in case this get merged... will the code eventually also end up in the 4.0 branch or does this require a separate PR?
basically yes it should do as george is pushing them all up (eventually)
however as this one uses external libraries iirc it might need to be changed so he might ask you to do a specific pr as we handle those differently in j4
he might ask you to do a specific pr
I'd love to do that.
Thanks!
You dont have to do anything.
I also love to do that
Thanks for the update.
Works fine, but the Save toolbar button may be an issue when switching from constant to value.
and even worse when there is a specific custom admin menu added.
That is unavoidable if someone wants this feature.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21691.
I suggest to add an onChange event in the form field to save and reload the page.
That would then be different to every other selector in the ui - so that would not be a good idea
I have tested this item
Tested successfully.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21691.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
I'm not going to block the merge on this but we need to update the Language class to not rely on pulling this param from the global config at all times (basically, the same way the class has a parameter to enable/disable debug mode we should have the same for this new capability).
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-09-08 15:32:40 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
Thanks for merging. Not sure I can do that change but I will try
I have tested this item✅ successfully on 1277199
There is an issue that debug settings are not immediately being applied so I guess testers might get confused?
Anyway - works😉
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21691.