Feeling Lucky
?
[#21688] - Update .CODEOWNERS after github nick change
- Fixed in Code Base
- 18 Aug 2018
- Medium
- Build: staging
- # 21688
- Diff
- wojsmol:codeowners
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Update .CODEOWNERS after github nick change
Testing Instructions
code review
Expected result
Actual result
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository |
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-08-18 14:21:24 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
zero-24
- comment
- 19 Aug 2018
As he still does not have merge access so it does not matter anyway :)
zero-24
- comment
- 19 Aug 2018
My point is the following:
People with admin or owner permissions can set up a CODEOWNERS file in a repository. The people you choose as code owners must have write permissions for the repository.
https://help.github.com/articles/about-codeowners/ As far as i understand that doc no mail and nor request is send out anyway ;)
brianteeman
- comment
- 19 Aug 2018
Correct
wojsmol
- comment
- 19 Aug 2018
One way or the other PR is valid because of nick change, permission part is repo admin thing.
zero-24
- comment
- 19 Aug 2018
Yes.
Always someone who has to change theirs? thanks!