? ? Success

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
18 Aug 2018

Pull Request for Issue #20885 .

Summary of Changes

Use the published date for the atom/rss feed if it is set

Testing Instructions

Access feed and check published date is used instead of creation date (when set) and that it falls back to creation date when the published date isn't set

Documentation Changes Required

n/a

avatar wilsonge wilsonge - open - 18 Aug 2018
avatar wilsonge wilsonge - change - 18 Aug 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Aug 2018
Category Libraries
avatar AndNovAtor
AndNovAtor - comment - 18 Aug 2018

continuous-integration/drone/pr "failed", PHP_CODESNIFFER says Usage of ELSE IF is discouraged; use ELSEIF instead (line 107, else if ($createdField))

bf07872 18 Aug 2018 avatar wilsonge PHPCS
avatar wilsonge wilsonge - change - 18 Aug 2018
Labels Added: ?
avatar wilsonge
wilsonge - comment - 18 Aug 2018

Fixed :)

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 28 Apr 2019
avatar Quy
Quy - comment - 15 May 2019

I have tested this item successfully on bf07872


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21684.

avatar Quy
Quy - comment - 15 May 2019

I have tested this item successfully on bf07872


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21684.

avatar Quy Quy - test_item - 15 May 2019 - Tested successfully
avatar SharkyKZ
SharkyKZ - comment - 17 May 2019

I have tested this item successfully on bf07872


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21684.

avatar SharkyKZ SharkyKZ - test_item - 17 May 2019 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 17 May 2019
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 17 May 2019

Status "Ready To Commit".

avatar HLeithner
HLeithner - comment - 17 May 2019

@wilsonge that would change every rss feed, I don't think that is a good idea to do this in a bugfix release.

avatar AndNovAtor
AndNovAtor - comment - 17 May 2019

@HLeithner , Joomla 3.9.3 was "bugfix" release, but it changes some small components logic (one file using was removed), and so many of compoents became "broken" (with 500 error). However this PM is realy BUGFIX and DOESN'T broke anything. So I think is a good idea - fixing the "bug" that is several YEARS old

avatar HLeithner
HLeithner - comment - 17 May 2019

@AndNovAtor which file got removed in 3.9.3 I can't find it and do you have a issue number for me?

This PR has another problem, you can't decide if you like the to show the publish date or the create date for the modification date, like on the normal frontend.

Anyway in my opinion this is a feature and 3.9 has a feature freeze.

@wilsonge please rebase to j4

avatar HLeithner HLeithner - close - 17 May 2019
avatar HLeithner HLeithner - change - 17 May 2019
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2019-05-17 08:15:42
Closed_By HLeithner
Labels Added: ?
Removed: J3 Issue
avatar AndNovAtor
AndNovAtor - comment - 17 May 2019

@HLeithner , >>you can't decide if you like the to show the publish date or the create date for the modification date, like on the normal frontend
CMN! Joomla itself DOESN'T have this feauture and chooses BAD variant for use - a lot of people ask about exactly publish update. Reread the issue that iniztialized this PM.
SO, I need to reopen the issue.... So many years, and here is still a using create date for publish date.

avatar AndNovAtor
AndNovAtor - comment - 17 May 2019

@HLeithner, >>Anyway in my opinion this is a feature and 3.9 has a feature freeze.
I think that it's a bug (read my last commen in my issue) =)
So I sad, that it's closed for Joomla 3, because Joomla 4 will not be used by MANY people even after release - because minimum php and mysql requerements, for examle.
But I agree that this PM is dead....

avatar mbabker
mbabker - comment - 17 May 2019

If this is going to get closed as a "new feature" then you might as well just do an entire code freeze on the 3.9 as everything can be considered either a new feature or a B/C break (yes, bug fixes are B/C breaks because they change a behavior).

avatar AndNovAtor
AndNovAtor - comment - 17 May 2019

@mbabker , @franz-wohlkoenig , btw, maybe we should create a new pull request for 3.9 branch (it was Joomla 3.8.[11] when this PM was created)? I can....

avatar wilsonge
wilsonge - comment - 17 May 2019

Can someone pick up porting this to J4 in this case. I'm busy trying to get J4 things in order before I go on holiday tomorrow

avatar Quy
Quy - comment - 17 May 2019

I consider it as a bug as the published date in the article does not match with the published date in the feed.

Details
    Written by Joomla	
    Category: Park Blog	
    Published: 15 May 2019 
    Hits: 0 
		<item>
			<title>First Blog Post</title>
			<link>http://localhost/Joomla_3.9.6-Stable-Full_Package/index.php/park-blog/17-first-blog-post</link>
			<guid isPermaLink="true">http://localhost/Joomla_3.9.6-Stable-Full_Package/index.php/park-blog/17-first-blog-post</guid>
			<description><![CDATA[<p><em>Lorem Ipsum is filler text that is commonly used by designers before the content for a new site is ready.</em></p>
<p>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Sed faucibus purus vitae diam posuere nec eleifend elit dictum. Aenean sit amet erat purus, id fermentum lorem. Integer elementum tristique lectus, non posuere quam pretium sed. Quisque scelerisque erat at urna condimentum euismod. Fusce vestibulum facilisis est, a accumsan massa aliquam in. In auctor interdum mauris a luctus. Morbi euismod tempor dapibus. Duis dapibus posuere quam. Pellentesque habitant morbi tristique senectus et netus et malesuada fames ac turpis egestas. In eu est nec erat sollicitudin hendrerit. Pellentesque sed turpis nunc, sit amet laoreet velit. Praesent vulputate semper nulla nec varius. Aenean aliquam, justo at blandit sodales, mauris leo viverra orci, sed sodales mauris orci vitae magna.</p>
]]></description>
			<category>Park Blog</category>
			<pubDate>Fri, 31 Dec 2010 23:00:01 +0000</pubDate>
		</item>
avatar AndNovAtor
AndNovAtor - comment - 3 Jun 2019

I recreated this PR with 25095 and 25106 (for 3.10-dev branch).
@mbabker, @franz-wohlkoenig, @wilsonge, @Quy, please check it.

Add a Comment

Login with GitHub to post a comment