?
avatar brianteeman
brianteeman
18 Aug 2018

Why do we have this complex rule for validating urls

class UrlRule extends FormRule

Wouldn't it be much easier to use the native php validation filters
http://php.net/manual/en/filter.filters.validate.php

avatar brianteeman brianteeman - open - 18 Aug 2018
avatar joomla-cms-bot joomla-cms-bot - change - 18 Aug 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 18 Aug 2018
avatar franz-wohlkoenig franz-wohlkoenig - change - 18 Aug 2018
Status New Discussion
avatar franz-wohlkoenig franz-wohlkoenig - change - 18 Aug 2018
Category com_mailto
avatar brianteeman
brianteeman - comment - 18 Aug 2018

and in most places we dont even use that rule when we really should
#13876

avatar ReLater
ReLater - comment - 18 Aug 2018

FILTER_VALIDATE_EMAIL : dotless domain names are not supported (e.g. dings@localhost).
FILTER_VALIDATE_URL : only find ASCII URLs to be valid.

I'm not absolutely sure if it was a Joomla discussion but as far as I remember that was the reason why FILTER_VALIDATE_EMAIL was refused in the past.

avatar brianteeman
brianteeman - comment - 19 Aug 2018

yes i should have updated to say i found out the dotless domain issue - thanks

luckily we should be able to use the html5 input type email

avatar brianteeman brianteeman - change - 28 Aug 2018
Labels Added: ?
avatar brianteeman brianteeman - labeled - 28 Aug 2018
avatar joomla-cms-bot joomla-cms-bot - change - 28 Aug 2018
Labels Removed: ?
avatar joomla-cms-bot joomla-cms-bot - unlabeled - 28 Aug 2018
avatar brianteeman brianteeman - change - 30 Oct 2018
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2018-10-30 19:43:37
Closed_By brianteeman
avatar brianteeman brianteeman - close - 30 Oct 2018

Add a Comment

Login with GitHub to post a comment