[#21673] - Allow filtering by archived in Redirect Manager
- Fixed in Code Base
- 21 Aug 2018
- Medium
- Build: staging
- # 21673
- Diff
- joomla:filter/archived-redirect-comp
- Pending continuous-integration/drone/push this build is pending Details
- Pending continuous-integration/appveyor/branch Waiting for AppVeyor build to complete Details
- Pending continuous-integration/travis-ci/push The Travis CI build is in progress Details
User tests: Successful: Unsuccessful:
Summary of Changes
Allows filtering by the archived state in the redirect component.
Testing Instructions
In search tools of the redirect component there is now an archived option in the dropdown which allows filtering by archived options
Documentation Changes Required
n/a
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Title |
|
||||||
| Title |
|
||||||
That's fine. But as it's currently still there it should work properly :)
or just merge mine to remove it ;)
there is no function in setting a redirect to archived so better to remove a useless function than to add features to a broken function
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21673.
I still dont see any reason to have the archive state for redirects as they have no function - so no need to filter etc
Provide examples of valid workflows where a distinction between a published and an archived redirect link should be supported. As pointed out in that issue, what you are using archived for is exactly what unpublished is, archived is not a "we've reviewed this link and decided to not redirect it anywhere" state. If anything, if archived is going to exist as a state it should be consistent with the state as used in other core components (i.e. archived in com_redirect and com_content should have a loosely similar definition).
I have tested this item
As discussed I still think it is wrong to have an archived state which does nothing but this PR does do what it aims to do
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21673.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-08-21 03:52:21 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
I created a pr some time ago to remove the archived state from com_redirects as it has no purpose that I could see