[#21667] - [4.0] [RFC] Optimize countItems and introduce component name
- Closed
- 29 Mar 2020
- Medium
- Build: 4.0-dev
- # 21667
- Diff
- HLeithner:workflow-countitems
- Success Hound No violations found. Woof! Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: 0 Unsuccessful: 0
This pull requests removes the countItems() function from contentComponent (will also be done for other components). As part of this PR a now Component variable is introduced because its not possible to detect the current component name in a ServiceTrait.
Now I would like to know if there is a better way to do this.
Summary of Changes
Removed ContentComponent::countItems
Update CategoriesServicesTrait::countItems to support WorkflowServiceInterface
Added $name variable to all "services" components
Testing Instructions
Test components using categories specially the numbers per publish state in the category overview.
Expected result
Works
Actual result
Should work
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_admin com_banners com_content com_menus com_modules com_templates Libraries |
I like the move of the countItems function. But the name attribute looks for me somehow not right. I would do in the trait a function like getWorkfloowExtensionNameand which returns the name per default out of the classname. If a component does something special, then there is a possibility to override it. Just an idea.
franz-wohlkoenig
- | Title |
|
||||||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-03-29 19:17:58 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
?
Removed: J4 Issue ? |
||
This is the follow up PR of #21641 discussion.