Something in the UI where I get some information about a failed request.
I see a pending request.
Latest from https://github.com/mbabker/joomla-cms/tree/dev/privacy
Labels |
Added:
?
|
Status | New | ⇒ | Discussion |
Category | ⇒ | com_csp |
If the site's mail sending is turned off completely then the requests can never actually work, the email to the data subject to validate the request will never go out. At a minimum checking this setting should be incorporated into the health check module, and we might want to do some conditional handling on the forms as well.
in joomla-projects/privacy-framework#230 i've just changed the order of the executed tasks
That's going to be too late. For the frontend we almost shouldn't even let the form be submitted if mail sending is turned off. Similar for the backend.
did you mean a check on the request controller, should it be on time?
In the model, don't even try to save it if mail sending is disabled. It is totally inactionable and at best a waste of bytes in the database (both frontend and backend).
In the view, show some kind of message saying the form can't be submitted because mail sending is disabled, possibly don't even show the forms at all (both frontend and backend).
Those two make sure the user doesn't waste time trying to do something that won't work to begin with.
Then, add to the health check module on the privacy component dashboard a check to ensure mail sending is enabled.
In the model, don't even try to save it if mail sending is disabled.
not only imo, even when we got an phpmailerException
we are too late as we are now without joomla-projects/privacy-framework#230 we already have stored the privacy request in the db
That's why there needs to be an explicit check on the configuration versus just relying on the mail API to fail out based on the config.
Guess we need also be able to handle requests, when there is an Exception sending the mail.
should be no mail no request
From my limited understanding I would agree.
@jeckodevelopment there is a wip joomla-projects/privacy-framework#230 there i'll add that status check too, stay tuned for the next days.....
Labels |
Added:
J3 Issue
|
Labels |
Added:
?
|
Labels |
Removed:
?
J3 Issue
|
Labels |
Added:
?
|
joomla-projects/privacy-framework#231 and joomla-projects/privacy-framework#232 should cover all aspects of this, plus the already in-place error handling when an actual email send fails.
Status | Discussion | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-08-18 17:05:57 |
Closed_By | ⇒ | mbabker |
Thanks!!
Where you as the submitter gets the information or where you as the siteowner gets the information?