? ?
avatar laoneo
laoneo
16 Aug 2018

Steps to reproduce the issue

  • Disable mailing
  • Create a request

Expected result

Something in the UI where I get some information about a failed request.

Actual result

I see a pending request.

System information (as much as possible)

Latest from https://github.com/mbabker/joomla-cms/tree/dev/privacy

avatar laoneo laoneo - open - 16 Aug 2018
avatar joomla-cms-bot joomla-cms-bot - change - 16 Aug 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 16 Aug 2018
avatar franz-wohlkoenig franz-wohlkoenig - change - 16 Aug 2018
Status New Discussion
avatar franz-wohlkoenig franz-wohlkoenig - change - 16 Aug 2018
Category com_csp
avatar brianteeman
brianteeman - comment - 16 Aug 2018

Where you as the submitter gets the information or where you as the siteowner gets the information?

avatar mbabker
mbabker - comment - 16 Aug 2018

If the site's mail sending is turned off completely then the requests can never actually work, the email to the data subject to validate the request will never go out. At a minimum checking this setting should be incorporated into the health check module, and we might want to do some conditional handling on the forms as well.

avatar alikon
alikon - comment - 16 Aug 2018

in joomla-projects/privacy-framework#230 i've just changed the order of the executed tasks

avatar mbabker
mbabker - comment - 16 Aug 2018

That's going to be too late. For the frontend we almost shouldn't even let the form be submitted if mail sending is turned off. Similar for the backend.

avatar alikon
alikon - comment - 16 Aug 2018

did you mean a check on the request controller, should it be on time?

avatar mbabker
mbabker - comment - 16 Aug 2018

In the model, don't even try to save it if mail sending is disabled. It is totally inactionable and at best a waste of bytes in the database (both frontend and backend).

In the view, show some kind of message saying the form can't be submitted because mail sending is disabled, possibly don't even show the forms at all (both frontend and backend).

Those two make sure the user doesn't waste time trying to do something that won't work to begin with.

Then, add to the health check module on the privacy component dashboard a check to ensure mail sending is enabled.

avatar alikon
alikon - comment - 16 Aug 2018

In the model, don't even try to save it if mail sending is disabled.

not only imo, even when we got an phpmailerException we are too late as we are now without joomla-projects/privacy-framework#230 we already have stored the privacy request in the db

avatar mbabker
mbabker - comment - 16 Aug 2018

That's why there needs to be an explicit check on the configuration versus just relying on the mail API to fail out based on the config.

avatar laoneo
laoneo - comment - 17 Aug 2018

Guess we need also be able to handle requests, when there is an Exception sending the mail.

avatar alikon
alikon - comment - 17 Aug 2018

should be no mail no request

avatar laoneo
laoneo - comment - 17 Aug 2018

From my limited understanding I would agree.

avatar jeckodevelopment
jeckodevelopment - comment - 17 Aug 2018

Well, it could result also in a new row in the Status Check:

immagine

To display at a glance that the system can't work because of the disabled mailing system.

avatar alikon
alikon - comment - 17 Aug 2018

@jeckodevelopment there is a wip joomla-projects/privacy-framework#230 there i'll add that status check too, stay tuned for the next days.....

avatar jeckodevelopment
jeckodevelopment - comment - 17 Aug 2018

Thanks @alikon !

avatar brianteeman brianteeman - change - 17 Aug 2018
Labels Added: J3 Issue
avatar brianteeman brianteeman - labeled - 17 Aug 2018
avatar brianteeman brianteeman - change - 17 Aug 2018
Labels Added: ?
avatar brianteeman brianteeman - labeled - 17 Aug 2018
avatar brianteeman brianteeman - change - 17 Aug 2018
Labels Removed: ? J3 Issue
avatar brianteeman brianteeman - unlabeled - 17 Aug 2018
avatar brianteeman brianteeman - unlabeled - 17 Aug 2018
avatar brianteeman brianteeman - change - 17 Aug 2018
Labels Added: ?
avatar brianteeman brianteeman - labeled - 17 Aug 2018
avatar mbabker
mbabker - comment - 18 Aug 2018

joomla-projects/privacy-framework#231 and joomla-projects/privacy-framework#232 should cover all aspects of this, plus the already in-place error handling when an actual email send fails.

avatar mbabker mbabker - change - 18 Aug 2018
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2018-08-18 17:05:57
Closed_By mbabker
avatar mbabker mbabker - close - 18 Aug 2018
avatar laoneo
laoneo - comment - 18 Aug 2018

Thanks!!

Add a Comment

Login with GitHub to post a comment