[#21641] - [4.0][Workflow] Remove com_content defaults from workflow code
- Fixed in Code Base
- 8 Sep 2018
- Medium
- Build: 4.0-dev
- # 21641
- Diff
- HLeithner:workflow-nocomcontent
User tests: Successful: Unsuccessful:
This is a cleanup PR to remove com_content references
Summary of Changes
Remove all 'com_content' constants from workflow code.
Testing Instructions
Create, Delete, Edit
for com_content
- articles
for com_workflow
- stages
- transitions
- workflows
Expected result
All works fine
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | SQL Administration com_admin Postgresql com_content com_workflow Front End Installation |
| Labels |
Added:
?
|
||
I thought it looks familiar - so can you close that one please
| Labels |
Added:
?
|
||
| Category | SQL Administration com_admin Postgresql com_content com_workflow Front End Installation | ⇒ | Administration com_workflow Libraries |
I have tested this item
Delete an Stage got Error (see Screenshot), but Stage is trashed.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21641.
Delete an Stage got Error (see Screenshot), but Stage is trashed.
Not sure if this is related, does this not happen with the dev-4.0 branch?
it happen with applied Pull Request.
This is unrelated seams to be a problem with state->stage renaming please open a new issue.
Not sure about this PR, the idea was to use com_content as fallback like in categories. If we remove this fallback (which is OK with me), we have to add checks and throw an error if extension is missing.
There is ni reason to let com content be the fallback, this only makes it more error prone.
I found 3 places where a 3rd party component would fail to use the workflow because com_content was hardcoded or the default fallback.
In my opinion the same should be done for categories.
I agree with this PR - we should remove com_content as the default but @bembelimen is correct we should probably hard bail if we can't find an extension.
Sure it should have correct amd useful error messages I will adopt this PR
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-09-08 09:58:15 |
| Closed_By | ⇒ | wilsonge |
LGTM!
that was a bit too early... I create a new PR fixing 2 things
This PR is based on #21585