? ? Pending

User tests: Successful: Unsuccessful:

avatar rdeutz
rdeutz
15 Aug 2018

Pull Request for Issue #21388

Summary of Changes

I have build a not-on-windows group and excluded the group from testing on php5.6.

The test I have excluded is still executed in our travis testing environment so not testing it on windows doesn't seems so bad.

Testing Instructions

Just look if the appveyor build run to the end

Expected result

appveyor build run thru

Actual result

appveyor build run in a timeout

avatar rdeutz rdeutz - open - 15 Aug 2018
avatar rdeutz rdeutz - change - 15 Aug 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 Aug 2018
Category Unit Tests
avatar wilsonge wilsonge - close - 16 Aug 2018
avatar wilsonge wilsonge - merge - 16 Aug 2018
avatar wilsonge wilsonge - change - 16 Aug 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-08-16 09:27:58
Closed_By wilsonge
Labels Added: ? ?
avatar wilsonge
wilsonge - comment - 16 Aug 2018

@rdeutz thinking about it can we also just add a @note in the doc block explaining why we disable on windows please

avatar rdeutz
rdeutz - comment - 17 Aug 2018

note added with c506eac

avatar wilsonge
wilsonge - comment - 17 Aug 2018

Can you do it with tabs not spaces :P

avatar rdeutz
rdeutz - comment - 18 Aug 2018

I hate my ide or better I hate that can't set it up properly ;-)

c8095c4

avatar dgrammatiko
dgrammatiko - comment - 18 Aug 2018

Sorry, not sorry, but can we get https://editorconfig.org in the project. Then tabs, spaces and line endings will be automagically ok!

avatar wojsmol
wojsmol - comment - 18 Aug 2018

@dgrammatiko We have it here I can do a PR to move it to this repo.

avatar rdeutz
rdeutz - comment - 18 Aug 2018

@wojsmol sounds good

avatar wojsmol
wojsmol - comment - 18 Aug 2018

Add a Comment

Login with GitHub to post a comment