J4 Issue ? Pending

User tests: Successful: Unsuccessful:

avatar chmst
chmst
15 Aug 2018

JAT has found several a11y issues in the SystemInformation View:

Summary of Changes

Remove the < form > tag, as this is not a form.
Remove empty Table Footers
Replace the < fieldset > Tag by < div >
Replace the < legend > by Table < caption >

Testing Instructions

There should be no visible difference in the View System Information before and after patch.

Test of accessibility with screenreader is required.

avatar chmst chmst - open - 15 Aug 2018
avatar chmst chmst - change - 15 Aug 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 Aug 2018
Category Administration com_admin
avatar chmst chmst - change - 15 Aug 2018
The description was changed
avatar chmst chmst - edited - 15 Aug 2018
avatar franz-wohlkoenig franz-wohlkoenig - change - 15 Aug 2018
Category Administration com_admin Accessibility Administration com_admin
avatar brianteeman
brianteeman - comment - 15 Aug 2018

There should be no visible difference in the View System Information before and after patch.

unfortunately thats not correct - without some markup for the caption element the caption is displayed in muted text at the bottom of the screen.
I would create a new sscss file here administrator\templates\atum\scss\pages\_com_admin.scss and add the markup there.

This will add the caption to the top - then you just need to address the font-size and wieght

caption {
  caption-side: top;
}

The rest looks good

avatar chmst
chmst - comment - 15 Aug 2018

Thank ou @brianteeman. What do you think about adding the "caption-side: top" into one of the general scss files? If there are more tables, not only in com_admin, they all could have captions.

avatar brianteeman
brianteeman - comment - 15 Aug 2018

Sure. That would work as well

avatar brianteeman
brianteeman - comment - 15 Aug 2018

Correction to my last comment -

although confusingly named
atum\scss\vendor\bootstrap
is not their code it is our overrides of their code. So I would put it in the _table.scss file

avatar chmst chmst - change - 15 Aug 2018
Labels Added: J4 Issue
avatar joomla-cms-bot joomla-cms-bot - change - 15 Aug 2018
Category Administration com_admin Accessibility Administration com_admin Templates (admin) Accessibility
avatar chmst chmst - change - 15 Aug 2018
Labels Added: ?
avatar chmst
chmst - comment - 15 Aug 2018

To say the thruth: I think it does not need a caption or headline at all in this screen. The caption repeats the name of the tab and gives no information.

avatar brianteeman
brianteeman - comment - 15 Aug 2018

To say the thruth: I think it does not need a caption or headline at all in this screen. The caption repeats the name of the tab and gives no information.

Just checked other tabbed interfaces in joomla and they dont have titles either so you are correct

avatar brianteeman
brianteeman - comment - 16 Aug 2018

If those strings are only.used here then they can be removed from the language files

avatar chmst
chmst - comment - 16 Aug 2018

This are the Tab names. They were repeated in the Headline / caption.

avatar brianteeman
brianteeman - comment - 16 Aug 2018

ok

avatar brianteeman
brianteeman - comment - 16 Aug 2018

I have tested this item successfully on 343c43f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21628.

avatar brianteeman brianteeman - test_item - 16 Aug 2018 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 19 Aug 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-08-19 14:47:21
Closed_By franz-wohlkoenig
avatar joomla-cms-bot joomla-cms-bot - change - 19 Aug 2018
Closed_Date 2018-08-19 14:47:21 2018-08-19 14:47:22
Closed_By franz-wohlkoenig joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 19 Aug 2018
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 19 Aug 2018

closed as requested at #21724


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21628.

avatar joomla-cms-bot
joomla-cms-bot - comment - 19 Aug 2018

Add a Comment

Login with GitHub to post a comment