? ? ? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
15 Aug 2018

Pull Request for Issue #21599 .

Summary of Changes

removed Undefined property: Joomla\CMS\Object\CMSObject::$id in /var/www/html/j4dev/layouts/joomla/edit/global.php

Testing Instructions

edit a plugin

avatar alikon alikon - open - 15 Aug 2018
avatar alikon alikon - change - 15 Aug 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 Aug 2018
Category Layout
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 15 Aug 2018

I have tested this item successfully on 57542fa


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21623.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 15 Aug 2018 - Tested successfully
avatar infograf768
infograf768 - comment - 15 Aug 2018

I had seen this error indeed before, but I am wondering concerning taking off these lines of code.
Are they necessary in some cases?

avatar alikon
alikon - comment - 15 Aug 2018

for what can i undestand NO, but consider that i'm still trying to understand workflow ?

avatar infograf768
infograf768 - comment - 15 Aug 2018

I did a grep for <?php echo JLayoutHelper::render('joomla.edit.global', $this); ?>
and it is used elsewhere than plugin edit without error (15 times in present 4.0).

Therefore I think we have to dig further.

avatar infograf768
infograf768 - comment - 15 Aug 2018

@bembelimen
What about this?

avatar alikon alikon - change - 15 Aug 2018
Labels Added: ?
avatar alikon
alikon - comment - 15 Aug 2018

@infograf768 i've made it a more conservative fix

avatar infograf768 infograf768 - test_item - 15 Aug 2018 - Tested successfully
avatar infograf768
infograf768 - comment - 15 Aug 2018

I have tested this item successfully on d0211c2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21623.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 15 Aug 2018 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 15 Aug 2018

I have tested this item successfully on d0211c2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21623.

avatar franz-wohlkoenig franz-wohlkoenig - change - 15 Aug 2018
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 15 Aug 2018

Ready to Commit after two successful tests.

avatar wilsonge
wilsonge - comment - 15 Aug 2018

Before merging this I just want to hear from @bembelimen exactly what this code is doing

avatar bembelimen
bembelimen - comment - 15 Aug 2018

To be honest, I have to guess, why it's implemented that way, because it was from the student. But what it does is: it makes sure, that the transitions will only be displayed when the "item" is not new. (New items have no transiton)

I think, this check should be implemented differently: The component should decide, if the field is visible or not, not the layout based on the ID.

avatar brianteeman
brianteeman - comment - 15 Aug 2018

its a bit of a problem if no one knows why the code is written this way - surprised

avatar infograf768
infograf768 - comment - 15 Aug 2018

Anyone to propose another patch?

avatar bembelimen
bembelimen - comment - 15 Aug 2018

its a bit of a problem if no one knows why the code is written this way - surprised

Because the developer decided to do it that way like all the code in Joomla! is written because someone decided to do it in a way or another.

It's important to know why the code is here => see my answer above...

avatar wilsonge
wilsonge - comment - 16 Aug 2018

OK Merging this so we loose the notice. But can someone open an issue to actually review what's going on here. I guess this is so on first save of the article you can't immediately transition. But that may not be a bad thing...

avatar wilsonge wilsonge - change - 16 Aug 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-08-16 09:25:17
Closed_By wilsonge
Labels Added: ? ?
avatar wilsonge wilsonge - close - 16 Aug 2018
avatar wilsonge wilsonge - merge - 16 Aug 2018
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 16 Aug 2018

@wilsonge will open an Issue.

Add a Comment

Login with GitHub to post a comment