User tests: Successful: Unsuccessful:
Pull Request for Issue #21599 .
removed Undefined property: Joomla\CMS\Object\CMSObject::$id in /var/www/html/j4dev/layouts/joomla/edit/global.php
edit a plugin
Status | New | ⇒ | Pending |
Category | ⇒ | Layout |
I had seen this error indeed before, but I am wondering concerning taking off these lines of code.
Are they necessary in some cases?
for what can i undestand NO, but consider that i'm still trying to understand workflow
I did a grep for <?php echo JLayoutHelper::render('joomla.edit.global', $this); ?>
and it is used elsewhere than plugin edit without error (15 times in present 4.0).
Therefore I think we have to dig further.
@bembelimen
What about this?
Labels |
Added:
?
|
@infograf768 i've made it a more conservative fix
I have tested this item
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
Before merging this I just want to hear from @bembelimen exactly what this code is doing
To be honest, I have to guess, why it's implemented that way, because it was from the student. But what it does is: it makes sure, that the transitions will only be displayed when the "item" is not new. (New items have no transiton)
I think, this check should be implemented differently: The component should decide, if the field is visible or not, not the layout based on the ID.
its a bit of a problem if no one knows why the code is written this way - surprised
Anyone to propose another patch?
its a bit of a problem if no one knows why the code is written this way - surprised
Because the developer decided to do it that way like all the code in Joomla! is written because someone decided to do it in a way or another.
It's important to know why the code is here => see my answer above...
OK Merging this so we loose the notice. But can someone open an issue to actually review what's going on here. I guess this is so on first save of the article you can't immediately transition. But that may not be a bad thing...
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-08-16 09:25:17 |
Closed_By | ⇒ | wilsonge | |
Labels |
Added:
?
?
|
I have tested this item✅ successfully on 57542fa
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21623.