[#21603] - [4.0] [a11y] Set login page title
- Fixed in Code Base
- 15 Aug 2018
- Medium
- Build: 4.0-dev
- # 21603
- Diff
- brianteeman:admin-login
User tests: Successful: Unsuccessful:
a11y rules says that every page should have a meaningfu title
This PR adds the title "Administrator Login - sitename" to the title on the login page
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
It's the page title in the browser not on screen so it depends a lot on the browser and most dont support rtl in the title
https://w3c.github.io/i18n-tests/results/native-user-interfaces
As it's a subjective thing which comes first, site name or title, I can try and change this pr to use the setting in the global.config.
I'm not too fussed. My question was just that - I just want to make sure we're not screwing things up again for RTL users
| Labels |
Added:
?
|
||
Scrub that idea - the option is only for the frontend
but I just checked and the page title for the admin is set with this
$document->setTitle($this->get('sitename') . ' - ' . Text::_('JADMINISTRATION'));
and is not RTL aware - so I just updated this PR to match the order with sitename first
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-08-15 15:19:48 |
| Closed_By | ⇒ | wilsonge |
OK Cool. i'm down. and if we do need to change it in the future shouldn't be too hard
thanks
For RTL Sites do we need to make this a sprintf rather than hardcoding it as 3 parts?