Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#21598] - [Drone] Add rips to drone on 4.0-dev

? ? Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
13 Aug 2018

Summary of Changes

We have a new partnership for a static code analysis tool as mentioned here:
https://developer.joomla.org/news/739-rips-becomes-joomla-official-code-analysis-partner.html

Add rips to drone on 4.0-dev based on (#20796)

This PR adds the tool to our CI pipeline.

Testing Instructions

Trigger a build in drone.

Expected result

Works.

cc @SniperSister

@wilsonge please await final confirmation before merging thanks.

avatar zero-24 zero-24 - open - 13 Aug 2018
avatar zero-24 zero-24 - change - 13 Aug 2018
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Aug 2018
Category ⇒ Unit Tests
avatar zero-24 zero-24 - change - 13 Aug 2018
Labels Added: ? ?
avatar rdeutz
rdeutz - comment - 14 Aug 2018

I would make it the last step after system tests

759eb63 26 Aug 2018 avatar zero-24 drone
avatar joomla-cms-bot joomla-cms-bot - change - 26 Aug 2018
Category Unit Tests ⇒ Unit Tests Modules Front End
avatar zero-24
zero-24 - comment - 26 Aug 2018

@rdeutz @wilsonge Please review & merge as this now enables the drone security checks on 4.0-dev too (this also fixes an code style issue that cause drone to fail now)

avatar joomla-cms-bot joomla-cms-bot - change - 26 Aug 2018
Category Unit Tests Modules Front End ⇒ Unit Tests
avatar wilsonge
wilsonge - comment - 26 Aug 2018

Leaving this for @rdeutz to approve

avatar zero-24
zero-24 - comment - 4 Sep 2018

This has now been integrated here: #21853 so we don't split up the different configs in the branches we use.

avatar zero-24 zero-24 - change - 4 Sep 2018
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-09-04 20:57:42
Closed_By ⇒ zero-24
avatar zero-24 zero-24 - close - 4 Sep 2018

Add a Comment

Login with GitHub to post a comment