[#21592] - [4.0] Workflow Transitions/Stages
- Fixed in Code Base
- 10 Sep 2018
- Medium
- Build: 4.0-dev
- # 21592
- Diff
- brianteeman:monday-stage
User tests: Successful: Unsuccessful:
- Change the editor field to a text field - I am sure you will never need a full wysiwyg editor here
- Add a label to the field called "Note"
- change the tmpl to get the list of fields from the xml instead of being hardcoded
- Add the content of the "note" to the list view. I really can't see the point in having the note if you can't see it in the list
(Same has been done for stages)
After
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_workflow Language & Strings |
| Labels |
Added:
?
?
|
||
Moved the name above the tabs for consistency
Something isnt correct here - probably a silly error by me - but the edit is not displaying the note or saving correctly. I will take another look in the morning unless some kind sole wants to submit a pr to my branch with the fix
You've added the fields tag. So the fields names have changed to e.g. jform[transition][description] instead of jform[description] before this PR. So you'll need to update the populateState function I would imagine
(just doing this off code review - please check what i've written before attempting anything)
Makes sense. Will check in the morning
And probably the getState
| Title |
|
||||||
OK now updated for stages and ready for testing
@bembelimen I think this is clearer in the edit view and also means you can see all the notes at once in the list view - hope you agree
In general I really like this PR, but two things:
- perhaps move the note field to the right?
- What is the reason for grouping the fields into the "transitions fields"? Will this be extended in some way, so we need the foreach in the tmpl? I would suggest to use fieldset only, so we have not this nested field naming George mentioned.
perhaps move the note field to the right?
I assume you mean in the list view? It is below to be consistent with similar additional information on other lists - also allows a bit more space and if it was to wrap onto a second line it will look better this way
What is the reason for grouping the fields into the "transitions fields"? Will this be extended in some way, so we need the foreach in the tmpl? I would suggest to use fieldset only, so we have not this nested field naming George mentioned.
We don't have nested fields anymore with this (that's when you use a "fields" tag) this just names the fieldsets, which is required for allowing plugins to add more custom fields (for example see what I've done with the groups view in #21696)
No I mean in the form view.
@wilsonge But there is a difference: you add the name to the fieldset, here we added a new "fields" tag: https://github.com/joomla/joomla-cms/pull/21592/files#diff-6d3a9c00497a5503546ac43bbad8023eR10
- Note - i think thats a just a matter of opinion - I dont care and am happy to move it
- Fields - my fault - didnt save the change - have pushed now
| Labels |
Added:
?
|
||
conflicts resolved
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-09-10 11:13:47 |
| Closed_By | ⇒ | wilsonge |
Thanks!
LGTM. Let's just get one test here