? ? ? Pending

User tests: Successful: Unsuccessful:

avatar HLeithner
HLeithner
13 Aug 2018

Pull Request for Issue # .

Summary of Changes

Introduce condition constants into com_content container used for the workflow. This provides the possibility to define conditions per component. This also reintroduce the archive condition in com_content.

Testing Instructions

  • You need the latest state/stages fixes from PR #21566
  • regenerate the autoloader
  • Test com_content frontend/backend with all stages.

Expected result

You should have a "archive" condition.

Additional

@alikon please check the db changes, you already did the enum change for postgresql

avatar HLeithner HLeithner - open - 13 Aug 2018
avatar HLeithner HLeithner - change - 13 Aug 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Aug 2018
Category SQL Administration com_admin com_content com_workflow Front End Installation Libraries
avatar HLeithner HLeithner - change - 13 Aug 2018
Labels Added: ?
avatar wilsonge
wilsonge - comment - 14 Aug 2018

OK can you fix conflicts here - then let's get this one tested

31a2fb2 14 Aug 2018 avatar HLeithner CS
avatar HLeithner HLeithner - change - 14 Aug 2018
Labels Added: ?
avatar HLeithner
HLeithner - comment - 14 Aug 2018

@wilsonge rebase done, @bembelimen can you retest the pr?

353dd28 15 Aug 2018 avatar HLeithner CS
avatar HLeithner
HLeithner - comment - 15 Aug 2018

@wilsonge may could you describe it for an idiot?

7e82fa4 15 Aug 2018 avatar HLeithner cs
avatar joomla-cms-bot joomla-cms-bot - change - 16 Aug 2018
Category SQL Administration com_admin com_content com_workflow Front End Installation Libraries SQL Administration com_admin Postgresql com_content com_workflow Front End Installation Libraries
avatar wilsonge
wilsonge - comment - 16 Aug 2018

Now you can fix codestyle again :D

1145e90 16 Aug 2018 avatar HLeithner cs
avatar HLeithner
HLeithner - comment - 16 Aug 2018

YaY

6a0332c 17 Aug 2018 avatar HLeithner Typo
avatar bembelimen bembelimen - test_item - 17 Aug 2018 - Tested successfully
avatar bembelimen
bembelimen - comment - 17 Aug 2018

I have tested this item successfully on 887f57e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21585.

avatar infograf768
infograf768 - comment - 17 Aug 2018

Looks ok, although I do not have anymore the Articles - Archived module available in the list of new modules to create and therefore can't test archived articles.
screen shot 2018-08-17 at 11 08 35

avatar HLeithner
HLeithner - comment - 17 Aug 2018

The module isn't part of this PR and should comeback when archive is restored. This PR is only the base that it is possible to do the archive behavior

avatar infograf768
infograf768 - comment - 17 Aug 2018

It is apparently replaced by a Module called Articles-List which is not in the list of modules (in the modules/ folder)
screen shot 2018-08-17 at 11 16 35

There we have a "Choose State" field where it looks like it displays a workflow with its default stages.
By default it is set to Archived and the result in frontend is not a display of the Archived articles

EDIT: In fact it is the archived module which denomination has changed to Articles - List...

avatar infograf768 infograf768 - test_item - 17 Aug 2018 - Tested successfully
avatar infograf768
infograf768 - comment - 17 Aug 2018

I have tested this item successfully on 887f57e

Let's this get in as other PRs are dependent from it.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21585.

avatar franz-wohlkoenig franz-wohlkoenig - change - 17 Aug 2018
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 17 Aug 2018

Ready to Commit after two successful tests.

avatar wilsonge wilsonge - change - 17 Aug 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-08-17 10:24:26
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 17 Aug 2018
avatar wilsonge wilsonge - merge - 17 Aug 2018

Add a Comment

Login with GitHub to post a comment