[#21577] - [4.0] Clean up and alpha-order imports
- Fixed in Code Base
- 12 Aug 2018
- Medium
- Build: 4.0-dev
- # 21577
- Diff
- roland-d:optimize-imports
User tests: Successful: Unsuccessful:
Summary of Changes
This PR only cleans up the imports by alpha-ordering them. After this we should enforce alpha-ordering the imports so we don't get fatal errors anymore because people add multiple includes.
For those on PhpStorm, you can enable the Optimize Imports in your commit window
Testing Instructions
There are no functional changes, everything should work as before.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
rdeutz
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-08-12 21:09:59 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
Yes, it is a feature in PhpStorm where it lets you optimize imports on
folders. I did check the results on every changed file if there were
changes because since files showed up as changed but had no changes.
On August 12, 2018 22:46:10 Brian Teeman notifications@github.com wrote:
Cool stuff - did you have a script?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or mute the thread.
Cool - thanks for doing this.
After this we should enforce alpha-ordering the imports so we don't get fatal errors anymore because people add multiple includes.
Could you add that to the styleguide please
@brianteeman Done
Superstar!!
Cool stuff - did you have a script?