? ? ? Pending

User tests: Successful: Unsuccessful:

avatar jeckodevelopment
jeckodevelopment
12 Aug 2018

Following #21566

Summary of Changes

Changed State to Stage

avatar jeckodevelopment jeckodevelopment - open - 12 Aug 2018
avatar jeckodevelopment jeckodevelopment - change - 12 Aug 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Aug 2018
Category Administration Language & Strings
avatar jeckodevelopment jeckodevelopment - change - 12 Aug 2018
Labels Added: ? ?
avatar wilsonge
wilsonge - comment - 12 Aug 2018

You need to change the XML file too :)

avatar Quy Quy - change - 12 Aug 2018
Title
State to Stage
[4.0] State to Stage
avatar joomla-cms-bot joomla-cms-bot - edited - 12 Aug 2018
avatar wilsonge
wilsonge - comment - 14 Aug 2018

@jeckodevelopment are you planning on fixing this one?

avatar jeckodevelopment
jeckodevelopment - comment - 14 Aug 2018

@wilsonge yes, which XML file?

avatar infograf768
infograf768 - comment - 14 Aug 2018

Hmm
See #21579

avatar jeckodevelopment jeckodevelopment - change - 14 Aug 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 14 Aug 2018
Category Administration Language & Strings Administration Language & Strings Front End Plugins
avatar jeckodevelopment
jeckodevelopment - comment - 14 Aug 2018

@wilsonge should be ok now

avatar wilsonge
wilsonge - comment - 14 Aug 2018

Sorry i missed the second pair of strings were the email. These constants need changing too :) https://github.com/jeckodevelopment/joomla-cms/blob/State2Stage/plugins/content/joomla/joomla.php#L517-L518

avatar infograf768
infograf768 - comment - 14 Aug 2018

Folks, as I said above, this is partly also taken care of in #21579

As I guess 21579 is quite important, can we combine please?

avatar jeckodevelopment
jeckodevelopment - comment - 14 Aug 2018

done @wilsonge
@infograf768 how to proceed?

avatar infograf768
infograf768 - comment - 14 Aug 2018

The best would be to propose a PR against Bembelimen branch "workflow-prevent-trashing"

https://github.com/bembelimen/joomla-cms/tree/workflow-prevent-trashing

avatar brianteeman
brianteeman - comment - 14 Aug 2018

Workflows has broken so much - just merge this and say thank you to those helping to fix it and worry about any merge conflicts later

avatar wilsonge wilsonge - merge - 14 Aug 2018
avatar wilsonge wilsonge - change - 14 Aug 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-08-14 14:44:01
Closed_By wilsonge
avatar wilsonge wilsonge - close - 14 Aug 2018

Add a Comment

Login with GitHub to post a comment