? ?
avatar brianteeman
brianteeman
10 Aug 2018

Save as copy has always saved as an unpublished item

With workflows out of the box without any changes it now saves as a published item

I am guessing because that is the default state in the default workflow.

Not saying if I think this change is good or bad but it absolutely must be documented as it will change the way that people work and the expected behaviour

avatar brianteeman brianteeman - open - 10 Aug 2018
avatar joomla-cms-bot joomla-cms-bot - change - 10 Aug 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 10 Aug 2018
avatar franz-wohlkoenig franz-wohlkoenig - change - 10 Aug 2018
Status New Discussion
avatar franz-wohlkoenig franz-wohlkoenig - change - 10 Aug 2018
Category com_workflow
avatar brianteeman brianteeman - change - 10 Aug 2018
Labels Added: J4 Issue
avatar brianteeman brianteeman - labeled - 10 Aug 2018
avatar ggppdk
ggppdk - comment - 10 Aug 2018

It is better to be make a small fix for this and save it as unpublished,

since usually the new record is unfinished content, that needs extra time and work to be finished

avatar rdeutz rdeutz - change - 10 Aug 2018
Labels Added: ?
avatar rdeutz rdeutz - labeled - 10 Aug 2018
avatar franz-wohlkoenig franz-wohlkoenig - change - 21 Aug 2018
Title
Workflow - save as copy
[4.0] Workflow - save as copy
avatar joomla-cms-bot joomla-cms-bot - edited - 21 Aug 2018
avatar bembelimen
bembelimen - comment - 24 Aug 2018

@ggppdk there is no guaranteed unpublished stage. The article should get the workflow assigned by the category and from there the default stage (because it has to walk through the workflow, too)

And yes, it needs very proper documentation!

avatar ggppdk
ggppdk - comment - 24 Aug 2018

i see

then what about having a default configuration of workflow that would behave like before ?

and then if someone modifies the default configuration of stages and transitions, etc
then one should be responsible to configure this too

also different but related question
what about if a category has 2 default stages ?

  • a default stage for people with core.edit.state on the category
  • a default stage for people without core.edit.state on the category

good idea ? possible ?
is this been worked in some PR already ?

avatar brianteeman
brianteeman - comment - 24 Aug 2018

That's what I meant in another issue that workflows is ignoring the acl

avatar infograf768
infograf768 - comment - 25 Aug 2018

IMHO, it is extremely important that save2copy behaves as before i.e. item saved as Unpublished.
We also use this in com_associations.
If it is impossible to force this because of the category workflow, an alert/warning should be displayed.

avatar ggppdk
ggppdk - comment - 25 Aug 2018

I am thinking

as said by @bembelimen
there is no guaranteed 'unpublished' stage

why not add the 2 default stages instead of 1 default stage (if possible as said above)

  • default for users with core.edit.state on category
  • default for users without core.edit.state on category

and then 'Save as copy' will use the default stage 'of not having core.edit.state',
thus it will work for default workflow configuration
and if someone has a customized workflow configuration, then it will behave in a similar way

avatar Bakual
Bakual - comment - 25 Aug 2018

While I understand the idea and requirement of a default workflow stage, it brings a lot of issues like this. There is also the issue that you can't choose the initial stage of an item when you create it, which brings its own issues.

Imho the only way to address this is to set a default workflow stage per state (at least for unpublished and published, ideally for all four possible states).
This way save2copy could use the default unpublished stage and when someone creates an article and has permission to publish it, he can directly publish it without going through each workflow stage first.

avatar brianteeman
brianteeman - comment - 25 Aug 2018

I don't understand why the ability to select a stage is not present all the time and I don't understand why there has to be a default. This is overcomplicating things for a reason I am yet to understand

avatar Bakual
Bakual - comment - 25 Aug 2018

I guess one reason is that at the time you create an article, you don't even know what workflow you will use. Because that depends on the category. This would need code similar to custom fields where the form is reloaded once you change the category.
For save2copy, you will somehow have to know what stage equals to "Unpublished", as there may be multiple stages with that state 0.

avatar brianteeman
brianteeman - comment - 25 Aug 2018

Yes I wrote the same thing on another issue

avatar brianteeman
brianteeman - comment - 25 Aug 2018

It was #21547

avatar Bakual
Bakual - comment - 25 Aug 2018

Indeed ?

avatar bembelimen
bembelimen - comment - 25 Aug 2018

I fully agree about a com_fields solution (Ajax + show initial stage) and perhaps multiple starting points.
I think this would solve a lot of issues user have here. I think I have a good solution for it, but one step after another.

One thing I completely disagree: save2copy to unpublished in every case. I think now we have the opportunity to be flexible as hell and give the users something they can decide. So the user should decide what he/she wants. But we should always deliver a default, so he/she does not have to decide.

avatar brianteeman
brianteeman - comment - 14 Oct 2018

Sorry @bembelimen I am losing track of the workflow issues - did you write the ajax solution?

avatar brianteeman brianteeman - change - 8 Nov 2018
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2018-11-08 13:17:45
Closed_By brianteeman
avatar brianteeman brianteeman - close - 8 Nov 2018
avatar franz-wohlkoenig franz-wohlkoenig - change - 20 Apr 2019
Labels Added: ?
Removed: J4 Issue ?
avatar franz-wohlkoenig franz-wohlkoenig - unlabeled - 20 Apr 2019

Add a Comment

Login with GitHub to post a comment