? Pending

User tests: Successful: Unsuccessful:

avatar bembelimen
bembelimen
10 Aug 2018

Pull Request for Issue #21527 .

Summary of Changes

As with the workflow, there is no direct trash function anymore but the trash transition will be defined with a workflow itself.

Testing Instructions

Look into the article list (backend)

Expected result

No trash button anymore

Actual result

Trashbutton without functionality

avatar bembelimen bembelimen - open - 10 Aug 2018
avatar bembelimen bembelimen - change - 10 Aug 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Aug 2018
Category Administration com_content
avatar brianteeman
brianteeman - comment - 10 Aug 2018

NO NO NO - this is not a fix

avatar brianteeman
brianteeman - comment - 10 Aug 2018

Seriously of you think that removing the delete button is the solution then I really give up.

avatar brianteeman
brianteeman - comment - 10 Aug 2018

This solution is as sensible as me doing a pull request to remove workflows as the way to solve all the issues with it.

avatar brianteeman brianteeman - change - 10 Aug 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-08-10 12:39:06
Closed_By brianteeman
Labels Added: ?
avatar brianteeman brianteeman - close - 10 Aug 2018
avatar bembelimen
bembelimen - comment - 10 Aug 2018

As there is no "trash" state anymore, that is indeed the solution, because the article have to follow the execution flow, no direct jump (same for published/unpublished)

avatar brianteeman
brianteeman - comment - 10 Aug 2018

Congratulations then on breaking every component in joomla

avatar infograf768
infograf768 - comment - 11 Aug 2018

@bembelimen

We can evidently trash ONE article at a time via the status of the article itself, but we can't trash anymore multiple articles at the same time, which indeed is not acceptable.

Same for other states...

avatar bembelimen
bembelimen - comment - 11 Aug 2018

@infograf768 as I said above, there is absolutly no sense in having a "publish", "unpublish" or "trash" button anymore, because you (as "the user") have to follow the workflow sequence and there are a lot of scenarios, where the article in the current status has no publish/unpublish/trash route at the moment. Or you have multiple trash opportunities at the same time, so that makes the trash button useless again.

But: if you (as "the user" again) want to skip the sequence and trash multiple articles as "batch", then you can now use the batch functionallity. There is a new option for batching multiple articles with a new state.

avatar brianteeman
brianteeman - comment - 11 Aug 2018

This is just plain wrong. No other way to put it. In fact even with this stupid and broken workflow code one can still have a delete button. You chose to reSolve the issue by simply deleting the button instead of adopting the sensible solution of checking the workflow to see if the user is able to delete something and then deciding to display the button or not.

avatar brianteeman
brianteeman - comment - 11 Aug 2018

Let's look at another scenario. Almost every component that exists in the joomlasphere has delete, publish and unpublished buttons in the toolbar. Unless they rewrite their code to use your workflow code they will all have those buttons. So after 15 years of an expected button that no one has ever suggested changing you are removing it, without consultation, discussion or testing just because it was easier for you to delete it than to fix it.

avatar infograf768
infograf768 - comment - 11 Aug 2018

Also, if we keep workflow in core, there will be —I hope— a way to disable it completely, which means that the toolbar buttons should remain in that case.

avatar rdeutz rdeutz - change - 26 Dec 2018
Status Closed New
Closed_Date 2018-08-10 12:39:06
Closed_By brianteeman
avatar rdeutz rdeutz - change - 26 Dec 2018
Status New Pending
avatar rdeutz rdeutz - reopen - 26 Dec 2018
avatar bembelimen bembelimen - change - 26 Dec 2018
The description was changed
avatar bembelimen bembelimen - edited - 26 Dec 2018
avatar bembelimen
bembelimen - comment - 26 Dec 2018

The trash button is still unnecessary at this position, because it's now in the dropdown menu. So the button can still be removed with this PR.

avatar infograf768
infograf768 - comment - 26 Dec 2018

I have tested this item successfully on 5e51aec


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21532.

avatar infograf768 infograf768 - test_item - 26 Dec 2018 - Tested successfully
avatar brianteeman
brianteeman - comment - 26 Dec 2018

so how do you trash multiple articles at once and how do you address the UI issue where every other list view has a trash button but com_content does not

avatar bembelimen
bembelimen - comment - 26 Dec 2018

Why does com_content have no trash button?
This PR just removed the non-working button...

avatar infograf768
infograf768 - comment - 26 Dec 2018

so how do you trash multiple articles at once

Select articles, click on Change Status TOOLBAR button and select Trash

avatar infograf768
infograf768 - comment - 27 Dec 2018

@wilsonge
I guess this can go in.

avatar wilsonge wilsonge - change - 29 Dec 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-12-29 17:55:51
Closed_By wilsonge
avatar wilsonge wilsonge - close - 29 Dec 2018
avatar wilsonge wilsonge - merge - 29 Dec 2018

Add a Comment

Login with GitHub to post a comment