? Pending

User tests: Successful: Unsuccessful:

avatar bembelimen
bembelimen
10 Aug 2018

Pull Request for Issue #21518 .

Summary of Changes

Removed unused helper methods and update count methods

@wilsonge

avatar bembelimen bembelimen - open - 10 Aug 2018
avatar bembelimen bembelimen - change - 10 Aug 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Aug 2018
Category Administration com_content JavaScript Repository
avatar wilsonge wilsonge - change - 10 Aug 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 10 Aug 2018
Category Administration com_content JavaScript Repository Administration com_content
avatar wilsonge
wilsonge - comment - 10 Aug 2018

let's leave archive here please

avatar bembelimen
bembelimen - comment - 10 Aug 2018

At the current status it makes no sense to habe it here, this will be readded with the refactoring, I think.

avatar infograf768
infograf768 - comment - 12 Aug 2018

Any change introduced by Workflow should be a conditional depending on the setting "Enable Workflows" for articles.
I.e. Nothing that existed before should be deleted/modified to let users choose to use workflow or not.

This means that the priority is to recover what has been deleted by workflow.

avatar brianteeman
brianteeman - comment - 12 Aug 2018

There is NO option to disable/enable workflows. You have no choice - this workflows pr completely replaces the current working system.

That is why I am so insistent that the code is correct. The only reason that the current/previous states still exist in the com-content table is for b/c with extensions eg content-modules. Although that is not true either as it will only write published/unpublished/trashed into that table and will not write archived.

The option that you are thinking of works the same as the one for custom fields. ie it hides/shows the menu admin links. The logic being that once you have workflows setup then you don't need to see it again. Yes the language string for both needs to be improved.

If people spent the time to truly test this workflows stuff in a real world scenario they would see why it is not ready at all and will require fundamental changes before it can even be considered. The fact that it ignores the ACL is the most critical to me.

avatar bembelimen
bembelimen - comment - 12 Aug 2018

@wilsonge I readded the initial archive variables and added the condition constants.

For now this is the current working status for merging. Archived will be improved (again), when @HLeithner finished the break up of the conditions (which is the next step for this PR)

avatar Quy Quy - change - 12 Aug 2018
Title
Revert helper
[4.0] Revert helper
avatar joomla-cms-bot joomla-cms-bot - edited - 12 Aug 2018
avatar wilsonge wilsonge - change - 13 Aug 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-08-13 00:06:51
Closed_By wilsonge
avatar wilsonge wilsonge - close - 13 Aug 2018
avatar wilsonge wilsonge - merge - 13 Aug 2018

Add a Comment

Login with GitHub to post a comment